]> jfr.im git - solanum.git/blobdiff - src/s_serv.c
Spring cleaning redux:
[solanum.git] / src / s_serv.c
index 5241afc74478b8aa59162948db7349ae480c76ee..cf0dd391456537fda29842f898ff9b1e7afed036 100644 (file)
 #include "msg.h"
 #include "reject.h"
 #include "sslproc.h"
-
-extern char *crypt();
+#include "capability.h"
+#include "s_assert.h"
 
 #ifndef INADDR_NONE
 #define INADDR_NONE ((unsigned int) 0xffffffff)
 #endif
 
-#ifndef HAVE_SOCKETPAIR
-static int inet_socketpair(int d, int type, int protocol, int sv[2]);
-#endif
-
 int MaxConnectionCount = 1;
 int MaxClientCount = 1;
 int refresh_user_links = 0;
@@ -76,25 +72,65 @@ static char buf[BUFSIZE];
  * because all servers that we talk to already do TS, and the kludged
  * extra argument to "PASS" takes care of checking that.  -orabidoo
  */
-struct Capability captab[] = {
-/*  name     cap     */
-       { "QS",         CAP_QS },
-       { "EX",         CAP_EX },
-       { "CHW",        CAP_CHW},
-       { "IE",         CAP_IE},
-       { "KLN",        CAP_KLN},
-       { "KNOCK",      CAP_KNOCK},
-       { "ZIP",        CAP_ZIP},
-       { "TB",         CAP_TB},
-       { "UNKLN",      CAP_UNKLN},
-       { "CLUSTER",    CAP_CLUSTER},
-       { "ENCAP",      CAP_ENCAP },
-       { "SERVICES",   CAP_SERVICE },
-       { "RSFNC",      CAP_RSFNC },
-       { "SAVE",       CAP_SAVE },
-       { "EUID",       CAP_EUID },
-       {0, 0}
-};
+struct CapabilityIndex *serv_capindex = NULL;
+
+unsigned int CAP_CAP;
+unsigned int CAP_QS;
+unsigned int CAP_EX;
+unsigned int CAP_CHW;
+unsigned int CAP_IE;
+unsigned int CAP_KLN;
+unsigned int CAP_ZIP;
+unsigned int CAP_KNOCK;
+unsigned int CAP_TB;
+unsigned int CAP_UNKLN;
+unsigned int CAP_CLUSTER;
+unsigned int CAP_ENCAP;
+unsigned int CAP_TS6;
+unsigned int CAP_SERVICE;
+unsigned int CAP_RSFNC;
+unsigned int CAP_SAVE;
+unsigned int CAP_EUID;
+unsigned int CAP_EOPMOD;
+unsigned int CAP_BAN;
+unsigned int CAP_MLOCK;
+
+/*
+ * initialize our builtin capability table. --nenolod
+ */
+void
+init_builtin_capabs(void)
+{
+       serv_capindex = capability_index_create("server capabilities");
+
+       /* These two are not set via CAPAB/GCAP keywords. */
+       CAP_CAP = capability_put_anonymous(serv_capindex);
+       CAP_TS6 = capability_put_anonymous(serv_capindex);
+
+       CAP_QS = capability_put(serv_capindex, "QS");
+       CAP_EX = capability_put(serv_capindex, "EX");
+       CAP_CHW = capability_put(serv_capindex, "CHW");
+       CAP_IE = capability_put(serv_capindex, "IE");
+       CAP_KLN = capability_put(serv_capindex, "KLN");
+       CAP_KNOCK = capability_put(serv_capindex, "KNOCK");
+       CAP_ZIP = capability_put(serv_capindex, "ZIP");
+       CAP_TB = capability_put(serv_capindex, "TB");
+       CAP_UNKLN = capability_put(serv_capindex, "UNKLN");
+       CAP_CLUSTER = capability_put(serv_capindex, "CLUSTER");
+       CAP_ENCAP = capability_put(serv_capindex, "ENCAP");
+       CAP_SERVICE = capability_put(serv_capindex, "SERVICES");
+       CAP_RSFNC = capability_put(serv_capindex, "RSFNC");
+       CAP_SAVE = capability_put(serv_capindex, "SAVE");
+       CAP_EUID = capability_put(serv_capindex, "EUID");
+       CAP_EOPMOD = capability_put(serv_capindex, "EOPMOD");
+       CAP_BAN = capability_put(serv_capindex, "BAN");
+       CAP_MLOCK = capability_put(serv_capindex, "MLOCK");
+
+       capability_require(serv_capindex, "QS");
+       capability_require(serv_capindex, "EX");
+       capability_require(serv_capindex, "IE");
+       capability_require(serv_capindex, "ENCAP");
+}
 
 static CNCB serv_connect_callback;
 static CNCB serv_connect_ssl_callback;
@@ -134,7 +170,7 @@ hunt_server(struct Client *client_p, struct Client *source_p,
        if(parc <= server || EmptyString(parv[server]) ||
           match(parv[server], me.name) || (strcmp(parv[server], me.id) == 0))
                return (HUNTED_ISME);
-       
+
        new = LOCAL_COPY(parv[server]);
 
        /*
@@ -158,41 +194,23 @@ hunt_server(struct Client *client_p, struct Client *source_p,
         * Again, if there are no wild cards involved in the server
         * name, use the hash lookup
         */
-       if(!target_p)
+       if(!target_p && wilds)
        {
-               if(!wilds)
-               {
-                       if(MyClient(source_p) || !IsDigit(parv[server][0]))
-                               sendto_one_numeric(source_p, ERR_NOSUCHSERVER,
-                                                  form_str(ERR_NOSUCHSERVER),
-                                                  parv[server]);
-                       return (HUNTED_NOSUCH);
-               }
-               else
+               RB_DLINK_FOREACH(ptr, global_serv_list.head)
                {
-                       target_p = NULL;
-
-                       RB_DLINK_FOREACH(ptr, global_client_list.head)
+                       if(match(new, ((struct Client *) (ptr->data))->name))
                        {
-                               if(match(new, ((struct Client *) (ptr->data))->name))
-                               {
-                                       target_p = ptr->data;
-                                       break;
-                               }
+                               target_p = ptr->data;
+                               break;
                        }
                }
        }
 
+       if(target_p && !IsRegistered(target_p))
+               target_p = NULL;
+
        if(target_p)
        {
-               if(!IsRegistered(target_p))
-               {
-                       sendto_one_numeric(source_p, ERR_NOSUCHSERVER,
-                                          form_str(ERR_NOSUCHSERVER),
-                                          parv[server]);
-                       return HUNTED_NOSUCH;
-               }
-
                if(IsMe(target_p) || MyClient(target_p))
                        return HUNTED_ISME;
 
@@ -297,15 +315,9 @@ try_connections(void *unused)
         * error afterwards if it fails.
         *   -- adrian
         */
-#ifndef HIDE_SERVERS_IPS
-       sendto_realops_snomask(SNO_GENERAL, L_ALL,
-                       "Connection to %s[%s] activated.",
-                       server_p->name, server_p->host);
-#else
        sendto_realops_snomask(SNO_GENERAL, L_ALL,
                        "Connection to %s activated",
                        server_p->name);
-#endif
 
        serv_connect(server_p, 0);
 }
@@ -317,6 +329,7 @@ check_server(const char *name, struct Client *client_p)
        struct server_conf *tmp_p;
        rb_dlink_node *ptr;
        int error = -1;
+       const char *encr;
 
        s_assert(NULL != client_p);
        if(client_p == NULL)
@@ -347,20 +360,32 @@ check_server(const char *name, struct Client *client_p)
                {
                        error = -2;
 
-                       if(ServerConfEncrypted(tmp_p))
+                       if(tmp_p->passwd)
                        {
-                               if(!strcmp(tmp_p->passwd, crypt(client_p->localClient->passwd,
-                                                               tmp_p->passwd)))
+                               if(ServerConfEncrypted(tmp_p))
                                {
-                                       server_p = tmp_p;
-                                       break;
+                                       encr = rb_crypt(client_p->localClient->passwd,
+                                                                       tmp_p->passwd);
+                                       if(encr != NULL && !strcmp(tmp_p->passwd, encr))
+                                       {
+                                               server_p = tmp_p;
+                                               break;
+                                       }
+                                       else
+                                               continue;
                                }
+                               else if(strcmp(tmp_p->passwd, client_p->localClient->passwd))
+                                       continue;
                        }
-                       else if(!strcmp(tmp_p->passwd, client_p->localClient->passwd))
+
+                       if(tmp_p->certfp)
                        {
-                               server_p = tmp_p;
-                               break;
+                               if(!client_p->certfp || strcasecmp(tmp_p->certfp, client_p->certfp) != 0)
+                                       continue;
                        }
+
+                       server_p = tmp_p;
+                       break;
                }
        }
 
@@ -396,28 +421,70 @@ check_server(const char *name, struct Client *client_p)
  *
  */
 void
-send_capabilities(struct Client *client_p, int cap_can_send)
+send_capabilities(struct Client *client_p, unsigned int cap_can_send)
 {
-       struct Capability *cap;
-       char msgbuf[BUFSIZE];
-       char *t;
-       int tl;
-
-       t = msgbuf;
+       sendto_one(client_p, "CAPAB :%s", capability_index_list(serv_capindex, cap_can_send));
+}
 
-       for (cap = captab; cap->name; ++cap)
+static void
+burst_ban(struct Client *client_p)
+{
+       rb_dlink_node *ptr;
+       struct ConfItem *aconf;
+       const char *type, *oper;
+       /* +5 for !,@,{,} and null */
+       char operbuf[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
+       char *p;
+       size_t melen;
+
+       melen = strlen(me.name);
+       RB_DLINK_FOREACH(ptr, prop_bans.head)
        {
-               if(cap->cap & cap_can_send)
+               aconf = ptr->data;
+
+               /* Skip expired stuff. */
+               if(aconf->lifetime < rb_current_time())
+                       continue;
+               switch(aconf->status & ~CONF_ILLEGAL)
+               {
+                       case CONF_KILL: type = "K"; break;
+                       case CONF_DLINE: type = "D"; break;
+                       case CONF_XLINE: type = "X"; break;
+                       case CONF_RESV_NICK: type = "R"; break;
+                       case CONF_RESV_CHANNEL: type = "R"; break;
+                       default:
+                               continue;
+               }
+               oper = aconf->info.oper;
+               if(aconf->flags & CONF_FLAGS_MYOPER)
                {
-                       tl = rb_sprintf(t, "%s ", cap->name);
-                       t += tl;
+                       /* Our operator{} names may not be meaningful
+                        * to other servers, so rewrite to our server
+                        * name.
+                        */
+                       rb_strlcpy(operbuf, aconf->info.oper, sizeof buf);
+                       p = strrchr(operbuf, '{');
+                       if (p != NULL &&
+                                       operbuf + sizeof operbuf - p > (ptrdiff_t)(melen + 2))
+                       {
+                               memcpy(p + 1, me.name, melen);
+                               p[melen + 1] = '}';
+                               p[melen + 2] = '\0';
+                               oper = operbuf;
+                       }
                }
+               sendto_one(client_p, ":%s BAN %s %s %s %lu %d %d %s :%s%s%s",
+                               me.id,
+                               type,
+                               aconf->user ? aconf->user : "*", aconf->host,
+                               (unsigned long)aconf->created,
+                               (int)(aconf->hold - aconf->created),
+                               (int)(aconf->lifetime - aconf->created),
+                               oper,
+                               aconf->passwd,
+                               aconf->spasswd ? "|" : "",
+                               aconf->spasswd ? aconf->spasswd : "");
        }
-
-       t--;
-       *t = '\0';
-
-       sendto_one(client_p, "CAPAB :%s", msgbuf);
 }
 
 /* burst_modes_TS6()
@@ -427,7 +494,7 @@ send_capabilities(struct Client *client_p, int cap_can_send)
  * side effects - client is sent a list of +b, +e, or +I modes
  */
 static void
-burst_modes_TS6(struct Client *client_p, struct Channel *chptr, 
+burst_modes_TS6(struct Client *client_p, struct Channel *chptr,
                rb_dlink_list *list, char flag)
 {
        rb_dlink_node *ptr;
@@ -445,7 +512,7 @@ burst_modes_TS6(struct Client *client_p, struct Channel *chptr,
        {
                banptr = ptr->data;
 
-               tlen = strlen(banptr->banstr) + 1;
+               tlen = strlen(banptr->banstr) + (banptr->forward ? strlen(banptr->forward) + 1 : 0) + 1;
 
                /* uh oh */
                if(cur_len + tlen > BUFSIZE - 3)
@@ -464,7 +531,10 @@ burst_modes_TS6(struct Client *client_p, struct Channel *chptr,
                        t = buf + mlen;
                }
 
-               rb_sprintf(t, "%s ", banptr->banstr);
+               if (banptr->forward)
+                       rb_sprintf(t, "%s$%s ", banptr->banstr, banptr->forward);
+               else
+                       rb_sprintf(t, "%s ", banptr->banstr);
                t += tlen;
                cur_len += tlen;
        }
@@ -478,7 +548,7 @@ burst_modes_TS6(struct Client *client_p, struct Channel *chptr,
 
 /*
  * burst_TS6
- * 
+ *
  * inputs      - client (server) to send nick towards
  *             - client to send nick for
  * output      - NONE
@@ -487,7 +557,7 @@ burst_modes_TS6(struct Client *client_p, struct Channel *chptr,
 static void
 burst_TS6(struct Client *client_p)
 {
-       static char ubuf[12];
+       char ubuf[BUFSIZE];
        struct Client *target_p;
        struct Channel *chptr;
        struct membership *msptr;
@@ -508,17 +578,17 @@ burst_TS6(struct Client *client_p)
                if(!IsPerson(target_p))
                        continue;
 
-               send_umode(NULL, target_p, 0, 0, ubuf);
+               send_umode(NULL, target_p, 0, ubuf);
                if(!*ubuf)
                {
                        ubuf[0] = '+';
                        ubuf[1] = '\0';
                }
 
-               if(has_id(target_p) && IsCapable(client_p, CAP_EUID))
+               if(IsCapable(client_p, CAP_EUID))
                        sendto_one(client_p, ":%s EUID %s %d %ld %s %s %s %s %s %s %s :%s",
                                   target_p->servptr->id, target_p->name,
-                                  target_p->hopcount + 1, 
+                                  target_p->hopcount + 1,
                                   (long) target_p->tsinfo, ubuf,
                                   target_p->username, target_p->host,
                                   IsIPSpoof(target_p) ? "0" : target_p->sockhost,
@@ -526,24 +596,20 @@ burst_TS6(struct Client *client_p)
                                   IsDynSpoof(target_p) ? target_p->orighost : "*",
                                   EmptyString(target_p->user->suser) ? "*" : target_p->user->suser,
                                   target_p->info);
-               else if(has_id(target_p))
+               else
                        sendto_one(client_p, ":%s UID %s %d %ld %s %s %s %s %s :%s",
                                   target_p->servptr->id, target_p->name,
-                                  target_p->hopcount + 1, 
+                                  target_p->hopcount + 1,
                                   (long) target_p->tsinfo, ubuf,
                                   target_p->username, target_p->host,
                                   IsIPSpoof(target_p) ? "0" : target_p->sockhost,
                                   target_p->id, target_p->info);
-               else
-                       sendto_one(client_p, "NICK %s %d %ld %s %s %s %s :%s",
-                                       target_p->name,
-                                       target_p->hopcount + 1,
-                                       (long) target_p->tsinfo,
-                                       ubuf,
-                                       target_p->username, target_p->host,
-                                       target_p->servptr->name, target_p->info);
-
-               if(!has_id(target_p) || !IsCapable(client_p, CAP_EUID))
+
+               if(!EmptyString(target_p->certfp))
+                       sendto_one(client_p, ":%s ENCAP * CERTFP :%s",
+                                       use_id(target_p), target_p->certfp);
+
+               if(!IsCapable(client_p, CAP_EUID))
                {
                        if(IsDynSpoof(target_p))
                                sendto_one(client_p, ":%s ENCAP * REALHOST %s",
@@ -593,7 +659,7 @@ burst_TS6(struct Client *client_p)
                                t = buf + mlen;
                        }
 
-                       rb_sprintf(t, "%s%s ", find_channel_status(msptr, 1), 
+                       rb_sprintf(t, "%s%s ", find_channel_status(msptr, 1),
                                   use_id(msptr->client_p));
 
                        cur_len += tlen;
@@ -628,6 +694,11 @@ burst_TS6(struct Client *client_p)
                                   ConfigChannel.burst_topicwho ? " " : "",
                                   chptr->topic);
 
+               if(IsCapable(client_p, CAP_MLOCK))
+                       sendto_one(client_p, ":%s MLOCK %ld %s :%s",
+                                  me.id, (long) chptr->channelts, chptr->chname,
+                                  EmptyString(chptr->mode_lock) ? "" : chptr->mode_lock);
+
                hchaninfo.chptr = chptr;
                call_hook(h_burst_channel, &hchaninfo);
        }
@@ -647,7 +718,8 @@ const char *
 show_capabilities(struct Client *target_p)
 {
        static char msgbuf[BUFSIZE];
-       struct Capability *cap;
+
+       *msgbuf = '\0';
 
        if(has_id(target_p))
                rb_strlcpy(msgbuf, " TS6", sizeof(msgbuf));
@@ -658,11 +730,8 @@ show_capabilities(struct Client *target_p)
        if(!IsServer(target_p) || !target_p->serv->caps)        /* short circuit if no caps */
                return msgbuf + 1;
 
-       for (cap = captab; cap->cap; ++cap)
-       {
-               if(cap->cap & target_p->serv->caps)
-                       rb_snprintf_append(msgbuf, sizeof(msgbuf), " %s", cap->name);
-       }
+       rb_strlcat(msgbuf, " ", sizeof(msgbuf));
+       rb_strlcat(msgbuf, capability_index_list(serv_capindex, target_p->serv->caps), sizeof(msgbuf));
 
        return msgbuf + 1;
 }
@@ -726,15 +795,9 @@ server_estab(struct Client *client_p)
 
        if(IsUnknown(client_p))
        {
-               /*
-                * jdc -- 1.  Use EmptyString(), not [0] index reference.
-                *        2.  Check ->spasswd, not ->passwd.
-                */
-               if(!EmptyString(server_p->spasswd))
-               {
-                       sendto_one(client_p, "PASS %s TS %d :%s", 
-                                  server_p->spasswd, TS_CURRENT, me.id);
-               }
+               /* the server may be linking based on certificate fingerprint now. --nenolod */
+               sendto_one(client_p, "PASS %s TS %d :%s",
+                          EmptyString(server_p->spasswd) ? "*" : server_p->spasswd, TS_CURRENT, me.id);
 
                /* pass info to new server */
                send_capabilities(client_p, default_server_capabs
@@ -764,11 +827,7 @@ server_estab(struct Client *client_p)
 
        SetServer(client_p);
 
-       /* Update the capability combination usage counts */
-       set_chcap_usage_counts(client_p);
-
        rb_dlinkAdd(client_p, &client_p->lnode, &me.serv->servers);
-       del_unknown_ip(client_p);
        rb_dlinkMoveNode(&client_p->localClient->tnode, &unknown_list, &serv_list);
        rb_dlinkAddTailAlloc(client_p, &global_serv_list);
 
@@ -794,13 +853,13 @@ server_estab(struct Client *client_p)
 
        if((rb_dlink_list_length(&lclient_list) + rb_dlink_list_length(&serv_list)) >
           (unsigned long)MaxConnectionCount)
-               MaxConnectionCount = rb_dlink_list_length(&lclient_list) + 
+               MaxConnectionCount = rb_dlink_list_length(&lclient_list) +
                                        rb_dlink_list_length(&serv_list);
 
        /* Show the real host/IP to admins */
        sendto_realops_snomask(SNO_GENERAL, L_ALL,
                        "Link with %s established: (%s) link",
-                       get_server_name(client_p, SHOW_IP),
+                       client_p->name,
                        show_capabilities(client_p));
 
        ilog(L_SERVER, "Link with %s established: (%s) link",
@@ -831,8 +890,7 @@ server_estab(struct Client *client_p)
                                   me.id, client_p->name, client_p->id,
                                   IsHidden(client_p) ? "(H) " : "", client_p->info);
 
-                       if(IsCapable(target_p, CAP_ENCAP) &&
-                          !EmptyString(client_p->serv->fullcaps))
+                       if(!EmptyString(client_p->serv->fullcaps))
                                sendto_one(target_p, ":%s ENCAP * GCAP :%s",
                                        client_p->id, client_p->serv->fullcaps);
                }
@@ -842,8 +900,7 @@ server_estab(struct Client *client_p)
                                   me.name, client_p->name,
                                   IsHidden(client_p) ? "(H) " : "", client_p->info);
 
-                       if(IsCapable(target_p, CAP_ENCAP) &&
-                          !EmptyString(client_p->serv->fullcaps))
+                       if(!EmptyString(client_p->serv->fullcaps))
                                sendto_one(target_p, ":%s ENCAP * GCAP :%s",
                                        client_p->name, client_p->serv->fullcaps);
                }
@@ -857,7 +914,7 @@ server_estab(struct Client *client_p)
         ** there are no NICK's to be cancelled...). Of course,
         ** if cancellation occurs, all this info is sent anyway,
         ** and I guess the link dies when a read is attempted...? --msa
-        ** 
+        **
         ** Note: Link cancellation to occur at this point means
         ** that at least two servers from my fragment are building
         ** up connection this other fragment at the same time, it's
@@ -887,13 +944,15 @@ server_estab(struct Client *client_p)
                                   target_p->name, target_p->hopcount + 1,
                                   IsHidden(target_p) ? "(H) " : "", target_p->info);
 
-               if(IsCapable(client_p, CAP_ENCAP) && 
-                  !EmptyString(target_p->serv->fullcaps))
+               if(!EmptyString(target_p->serv->fullcaps))
                        sendto_one(client_p, ":%s ENCAP * GCAP :%s",
                                        get_id(target_p, client_p),
                                        target_p->serv->fullcaps);
        }
 
+       if(IsCapable(client_p, CAP_BAN))
+               burst_ban(client_p);
+
        burst_TS6(client_p);
 
        /* Always send a PING after connect burst is done */
@@ -901,8 +960,7 @@ server_estab(struct Client *client_p)
 
        free_pre_client(client_p);
 
-       if (!IsCapable(client_p, CAP_ZIP))
-               send_pop_queue(client_p);
+       send_pop_queue(client_p);
 
        return 0;
 }
@@ -924,7 +982,7 @@ serv_connect_resolved(struct Client *client_p)
        if((server_p = client_p->localClient->att_sconf) == NULL)
        {
                sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL, "Lost connect{} block for %s",
-                               get_server_name(client_p, HIDE_IP));
+                               client_p->name);
                exit_client(client_p, client_p, &me, "Lost connect{} block");
                return 0;
        }
@@ -938,23 +996,23 @@ serv_connect_resolved(struct Client *client_p)
 
        if(ServerConfVhosted(server_p))
        {
-               memcpy(&myipnum, &server_p->my_ipnum, sizeof(myipnum));
+               memcpy(&myipnum, &server_p->my_ipnum, sizeof(server_p->my_ipnum));
                ((struct sockaddr_in *)&myipnum)->sin_port = 0;
                myipnum.ss_family = server_p->aftype;
-                               
+
        }
        else if(server_p->aftype == AF_INET && ServerInfo.specific_ipv4_vhost)
        {
-               memcpy(&myipnum, &ServerInfo.ip, sizeof(myipnum));
+               memcpy(&myipnum, &ServerInfo.ip, sizeof(ServerInfo.ip));
                ((struct sockaddr_in *)&myipnum)->sin_port = 0;
                myipnum.ss_family = AF_INET;
                SET_SS_LEN(&myipnum, sizeof(struct sockaddr_in));
        }
-       
+
 #ifdef RB_IPV6
        else if((server_p->aftype == AF_INET6) && ServerInfo.specific_ipv6_vhost)
        {
-               memcpy(&myipnum, &ServerInfo.ip6, sizeof(myipnum));
+               memcpy(&myipnum, &ServerInfo.ip6, sizeof(ServerInfo.ip6));
                ((struct sockaddr_in6 *)&myipnum)->sin6_port = 0;
                myipnum.ss_family = AF_INET6;
                SET_SS_LEN(&myipnum, sizeof(struct sockaddr_in6));
@@ -972,12 +1030,12 @@ serv_connect_resolved(struct Client *client_p)
                if(ServerConfSSL(server_p))
                {
                        rb_connect_tcp(client_p->localClient->F, (struct sockaddr *)&client_p->localClient->ip,
-                                        NULL, 0, serv_connect_ssl_callback, 
+                                        NULL, 0, serv_connect_ssl_callback,
                                         client_p, ConfigFileEntry.connect_timeout);
                }
                else
                        rb_connect_tcp(client_p->localClient->F, (struct sockaddr *)&client_p->localClient->ip,
-                                        NULL, 0, serv_connect_callback, 
+                                        NULL, 0, serv_connect_callback,
                                         client_p, ConfigFileEntry.connect_timeout);
                 return 1;
        }
@@ -1017,7 +1075,7 @@ serv_connect_dns_callback(void *vptr, struct DNSReply *reply)
        if (reply == NULL)
        {
                sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL, "Cannot resolve hostname for %s",
-                               get_server_name(client_p, HIDE_IP));
+                               client_p->name);
                ilog(L_SERVER, "Cannot resolve hostname for %s",
                                log_client_name(client_p, HIDE_IP));
                exit_client(client_p, client_p, &me, "Cannot resolve hostname");
@@ -1045,7 +1103,7 @@ serv_connect_dns_callback(void *vptr, struct DNSReply *reply)
 /*
  * serv_connect() - initiate a server connection
  *
- * inputs      - pointer to conf 
+ * inputs      - pointer to conf
  *             - pointer to client doing the connet
  * output      -
  * side effects        -
@@ -1078,10 +1136,10 @@ serv_connect(struct server_conf *server_p, struct Client *by)
        {
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Server %s already present from %s",
-                                    server_p->name, get_server_name(client_p, SHOW_IP));
+                                    server_p->name, client_p->name);
                if(by && IsPerson(by) && !MyClient(by))
                        sendto_one_notice(by, ":Server %s already present from %s",
-                                         server_p->name, get_server_name(client_p, SHOW_IP));
+                                         server_p->name, client_p->name);
                return 0;
        }
 
@@ -1135,7 +1193,8 @@ serv_connect(struct server_conf *server_p, struct Client *by)
        make_server(client_p);
        if(by && IsPerson(by))
        {
-               strcpy(client_p->serv->by, by->name);
+               rb_strlcpy(client_p->serv->by, by->name,
+                               sizeof client_p->serv->by);
                if(client_p->serv->user)
                        free_user(client_p->serv->user, NULL);
                client_p->serv->user = by->user;
@@ -1143,7 +1202,8 @@ serv_connect(struct server_conf *server_p, struct Client *by)
        }
        else
        {
-               strcpy(client_p->serv->by, "AutoConn.");
+               rb_strlcpy(client_p->serv->by, "AutoConn.",
+                               sizeof client_p->serv->by);
                if(client_p->serv->user)
                        free_user(client_p->serv->user, NULL);
                client_p->serv->user = NULL;
@@ -1184,37 +1244,37 @@ serv_connect(struct server_conf *server_p, struct Client *by)
        }
 }
 
-static void
-serv_connect_ev(void *data)
-{
-       struct Client *client_p = data;
-       serv_connect_callback(client_p->localClient->F, RB_OK, client_p);
-}
-
 static void
 serv_connect_ssl_callback(rb_fde_t *F, int status, void *data)
 {
        struct Client *client_p = data;
        rb_fde_t *xF[2];
+       rb_connect_sockaddr(F, (struct sockaddr *)&client_p->localClient->ip, sizeof(client_p->localClient->ip));
        if(status != RB_OK)
        {
-               /* XXX deal with failure */
+               /* Print error message, just like non-SSL. */
+               serv_connect_callback(F, status, data);
                return;
        }
-       rb_connect_sockaddr(F, (struct sockaddr *)&client_p->localClient->ip, sizeof(client_p->localClient->ip));
-       rb_socketpair(AF_UNIX, SOCK_STREAM, 0, &xF[0], &xF[1], "Outgoing ssld connection");
+       if(rb_socketpair(AF_UNIX, SOCK_STREAM, 0, &xF[0], &xF[1], "Outgoing ssld connection") == -1)
+       {
+                ilog_error("rb_socketpair failed for server");
+               serv_connect_callback(F, RB_ERROR, data);
+               return;
+
+       }
        del_from_cli_fd_hash(client_p);
        client_p->localClient->F = xF[0];
        add_to_cli_fd_hash(client_p);
 
        client_p->localClient->ssl_ctl = start_ssld_connect(F, xF[1], rb_get_fd(xF[0]));
        SetSSL(client_p);
-       rb_event_addonce("serv_connect_ev", serv_connect_ev, client_p, 1);              
+       serv_connect_callback(client_p->localClient->F, RB_OK, client_p);
 }
 
 /*
  * serv_connect_callback() - complete a server connection.
- * 
+ *
  * This routine is called after the server connection attempt has
  * completed. If unsucessful, an error is sent to ops and the client
  * is closed. If sucessful, it goes through the initialisation/check
@@ -1257,12 +1317,8 @@ serv_connect_callback(rb_fde_t *F, int status, void *data)
                {
                        sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL,
                                        "Error connecting to %s[%s]: %s",
-                                       client_p->name, 
-#ifdef HIDE_SERVERS_IPS
+                                       client_p->name,
                                        "255.255.255.255",
-#else
-                                       client_p->host,
-#endif
                                        rb_errstr(status));
                        ilog(L_SERVER, "Error connecting to %s[%s]: %s",
                                client_p->name, client_p->sockhost,
@@ -1274,11 +1330,7 @@ serv_connect_callback(rb_fde_t *F, int status, void *data)
                        sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL,
                                        "Error connecting to %s[%s]: %s (%s)",
                                        client_p->name,
-#ifdef HIDE_SERVERS_IPS
                                        "255.255.255.255",
-#else
-                                       client_p->host,
-#endif
                                        rb_errstr(status), errstr);
                        ilog(L_SERVER, "Error connecting to %s[%s]: %s (%s)",
                                client_p->name, client_p->sockhost,
@@ -1294,7 +1346,7 @@ serv_connect_callback(rb_fde_t *F, int status, void *data)
        if((server_p = client_p->localClient->att_sconf) == NULL)
        {
                sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL, "Lost connect{} block for %s",
-                               get_server_name(client_p, HIDE_IP));
+                               client_p->name);
                exit_client(client_p, client_p, &me, "Lost connect{} block");
                return;
        }
@@ -1302,14 +1354,9 @@ serv_connect_callback(rb_fde_t *F, int status, void *data)
        /* Next, send the initial handshake */
        SetHandshake(client_p);
 
-       /* kludge, if we're not using TS6, dont ever send
-        * ourselves as being TS6 capable.
-        */
-       if(!EmptyString(server_p->spasswd))
-       {
-               sendto_one(client_p, "PASS %s TS %d :%s", 
-                          server_p->spasswd, TS_CURRENT, me.id);
-       }
+       /* the server may be linking based on certificate fingerprint now. --nenolod */
+       sendto_one(client_p, "PASS %s TS %d :%s",
+                  EmptyString(server_p->spasswd) ? "*" : server_p->spasswd, TS_CURRENT, me.id);
 
        /* pass my info to the new server */
        send_capabilities(client_p, default_server_capabs
@@ -1320,7 +1367,7 @@ serv_connect_callback(rb_fde_t *F, int status, void *data)
                   me.name,
                   ConfigServerHide.hidden ? "(H) " : "", me.info);
 
-       /* 
+       /*
         * If we've been marked dead because a send failed, just exit
         * here now and save everyone the trouble of us ever existing.
         */
@@ -1337,60 +1384,3 @@ serv_connect_callback(rb_fde_t *F, int status, void *data)
        /* If we get here, we're ok, so lets start reading some data */
        read_packet(F, client_p);
 }
-
-#ifndef HAVE_SOCKETPAIR
-static int
-inet_socketpair(int d, int type, int protocol, int sv[2])
-{
-       struct sockaddr_in addr1, addr2, addr3;
-       int addr3_len = sizeof(addr3);
-       int fd, rc;
-       int port_no = 20000;
-       
-       if(d != AF_INET || type != SOCK_STREAM || protocol)
-       {
-               errno = EAFNOSUPPORT;
-               return -1;
-       }
-       if(((sv[0] = socket(AF_INET, SOCK_STREAM, 0)) < 0) || ((sv[1] = socket(AF_INET, SOCK_STREAM, 0)) < 0))
-               return -1;
-       
-       addr1.sin_port = htons(port_no);
-       addr1.sin_family = AF_INET;
-       addr1.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
-       while ((rc = bind (sv[0], (struct sockaddr *) &addr1, sizeof (addr1))) < 0 && errno == EADDRINUSE)
-               addr1.sin_port = htons(++port_no);
-       
-       if(rc < 0)
-               return -1;
-       
-       if(listen(sv[0], 1) < 0)
-       {
-               close(sv[0]);
-               close(sv[1]);
-               return -1;
-       }
-       
-       addr2.sin_port = htons(port_no);
-       addr2.sin_family = AF_INET;
-       addr2.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
-       if(connect (sv[1], (struct sockaddr *) &addr2, sizeof (addr2)) < 0) 
-       {
-               close(sv[0]);
-               close(sv[1]);
-               return -1;
-       }
-       
-       if((fd = accept(sv[1], (struct sockaddr *) &addr3, &addr3_len)) < 0)
-       {
-               close(sv[0]);
-               close(sv[1]);
-               return -1;
-       }
-       close(sv[0]);
-       sv[0] = fd;
-       
-       return(0);
-
-}
-#endif