From: Bram Matthys <redacted>
Date: Mon, 27 Mar 2023 08:56:52 +0000 (+0200)
Subject: Don't call channel.get() twice for simple GET requests.
X-Git-Tag: 0.9~271
X-Git-Url: https://jfr.im/git/irc/unrealircd/unrealircd-webpanel.git/commitdiff_plain/72e61f7621bec443a4c99c604645e630d6fd31f3

Don't call channel.get() twice for simple GET requests.
$_POST always exists even for GET requests, so isset() always
returned 1 and then... yeah...

Also, prepare to fetch more details...
---

diff --git a/channels/details.php b/channels/details.php
index 3e22fd3..115d242 100644
--- a/channels/details.php
+++ b/channels/details.php
@@ -13,7 +13,7 @@ do_log($_POST);
 if (isset($_GET['chan']))
 {
 	$channel = $_GET['chan'];
-	$channelObj = $rpc->channel()->get($channel);
+	$channelObj = $rpc->channel()->get($channel, 4);
 	if (!$channelObj && strlen($channel))
 	{
 		Message::Fail("Could not find channel: \"$channel\"");
@@ -31,7 +31,7 @@ $del_ban = false;
 $checkboxes = [];
 
 $chanban_errors = [];
-if (isset($_POST))
+if (!empty($_POST))
 {
 	if (isset($_POST['update_topic']) && isset($_POST['set_topic']))
 	{
@@ -152,9 +152,8 @@ if (isset($_POST))
 			Message::Success($msgbox_str);
 		}
 	}
-	/* and finally re-grab the channel because updates lol */
-	$channelObj = $rpc->channel()->get($channel);
-
+	/* Re-grab the channel because of updates */
+	$channelObj = $rpc->channel()->get($channel, 4);
 }
 
 ?>