X-Git-Url: https://jfr.im/git/irc/unrealircd/unrealircd-webpanel.git/blobdiff_plain/9c9d2cdf20255611576f6701658551d342f7b4d3..67bff06aa6fd4d7d3a9aefc2919307326fa6d755:/api/common_api.php

diff --git a/api/common_api.php b/api/common_api.php
index 3681d0a..ccb1442 100644
--- a/api/common_api.php
+++ b/api/common_api.php
@@ -1,5 +1,5 @@
 <?php
-include "../common.php";
+include "../inc/common.php";
 
 if(session_status() !== PHP_SESSION_ACTIVE) session_start();
 
@@ -9,11 +9,23 @@ if (!isset($_SESSION['id']))
 // Close the session now, otherwise other pages block
 session_write_close();
 
+// Apache w/FPM is shit because it doesn't have flushpackets=on
+// or not by default anyway, so we will fill up 4k buffers.
+// Yeah, really silly... I know.
+$fpm_workaround_needed = false;
+if (str_contains($_SERVER['SERVER_SOFTWARE'], 'Apache') &&
+    function_exists('fpm_get_status') &&
+    is_array(fpm_get_status()))
+{
+    $fpm_workaround_needed = true;
+}
+
 // Only now make the connection (this can take a short while)
-include "../connection.php";
+include "../inc/connection.php";
 
 // Server Side Events
-header('Content-Type: text/event-stream');
+if (!defined('NO_EVENT_STREAM_HEADER'))
+	header('Content-Type: text/event-stream');
 
 // Explicitly disable caching so Varnish and other upstreams won't cache.
 header("Cache-Control: no-cache, must-revalidate");
@@ -28,22 +40,38 @@ set_time_limit(0);
 // Send content immediately
 ob_implicit_flush(1);
 
-// Eh.. yeah...
-ob_end_flush();
+// Flush and stop output buffering (eg fastcgi w/NGINX)
+function flush_completely()
+{
+	while (1)
+	{
+		try {
+			$ret = @ob_end_flush();
+			if ($ret === false)
+				break;
+		} catch(Exception $e)
+		{
+			break;
+		}
+	}
+}
 
-// If we use fastcgi, then finish the request now (UNTESTED)
-if (function_exists('fastcgi_finish_request'))
-	fastcgi_finish_request();
+flush_completely();
 
 /* Send server-sent events (SSE) message */
 function send_sse($json)
 {
-	echo "data: ".json_encode($json)."\n\n";
+	GLOBAL $fpm_workaround_needed;
+	$str = "data: ".json_encode($json)."\n\n";
+	if ($fpm_workaround_needed)
+		$str .= str_repeat(" ", 4096 - ((strlen($str)+1) % 4096))."\n";
+	echo $str;
 }
 
 function api_log_loop($sources)
 {
 	GLOBAL $rpc;
+	GLOBAL $fpm_workaround_needed;
 
 	$rpc->log()->subscribe($sources);
 	if ($rpc->error)
@@ -56,7 +84,17 @@ function api_log_loop($sources)
 	{
 		$res = $rpc->eventloop();
 		if (!$res)
+		{
+			/* Output at least something every timeout (10) seconds,
+			 * otherwise PHP may not
+			 * notice when the webclient is gone.
+			 */
+			if ($fpm_workaround_needed)
+				echo str_repeat(" ", 4095)."\n";
+			else
+				echo "\n";
 			continue;
+		}
 		send_sse($res);
 	}
 }
@@ -65,6 +103,11 @@ function api_timer_loop(int $every_msec, string $method, array|null $params = nu
 {
 	GLOBAL $rpc;
 
+	/* First, execute it immediately */
+	$res = $rpc->query($method, $params);
+	if (!$res)
+		die;
+	send_sse($res);
 	$rpc->rpc()->add_timer("timer", $every_msec, $method, $params);
 	if ($rpc->error)
 	{
@@ -75,15 +118,32 @@ function api_timer_loop(int $every_msec, string $method, array|null $params = nu
 			if (!$res)
 				die;
 			send_sse($res);
+			usleep($every_msec * 1000);
 		}
 	}
 
 	/* New style: use server-side timers */
+	/* - First, execute it immediately */
+	$res = $rpc->query($method, $params);
+	if (!$res)
+		die;
+	send_sse($res);
+	/* - Then add the timer */
 	for(;;)
 	{
 		$res = $rpc->eventloop();
 		if (!$res)
+		{
+			/* Output at least something every timeout (10) seconds,
+			 * otherwise PHP may not
+			 * notice when the webclient is gone.
+			 */
+			if ($fpm_workaround_needed)
+				echo str_repeat(" ", 4095)."\n";
+			else
+				echo "\n";
 			continue;
+		}
 		send_sse($res);
 	}
 }