From: JD Horelick <redacted>
Date: Wed, 19 Jan 2011 20:41:23 +0000 (-0500)
Subject: Implement operspy for /LIST.
X-Git-Url: https://jfr.im/git/irc/rqf/shadowircd.git/commitdiff_plain/e78f804d42d584060d7661d5871ae1f750ea77df

Implement operspy for /LIST.
---

diff --git a/help/opers/operspy b/help/opers/operspy
index 2b60cc0..3633d77 100644
--- a/help/opers/operspy
+++ b/help/opers/operspy
@@ -12,3 +12,4 @@ mode !#channel  - Gives the full modes of a channel including any keys.
 chantrace !#channel - Gives full output despite not being on channel.
 masktrace !nick!user@host :gecos - Lists matching users on all servers.
 topic !#channel - Gives full output despite not being on channel.
+list ![,options...] - Lists all channels, including secret channels.
diff --git a/include/client.h b/include/client.h
index da61c85..24bbf67 100644
--- a/include/client.h
+++ b/include/client.h
@@ -306,6 +306,7 @@ struct ListClient
 {
 	unsigned int hash_indice;
 	unsigned int users_min, users_max;
+	int operspy;
 
 	/* It would be nice to add other modifiers,
 	 * but not for 1.1 --nenolod
diff --git a/modules/m_list.c b/modules/m_list.c
index f454037..0274443 100644
--- a/modules/m_list.c
+++ b/modules/m_list.c
@@ -40,6 +40,7 @@
 #include "ircd.h"
 #include "numeric.h"
 #include "s_conf.h"
+#include "s_newconf.h"
 #include "s_serv.h"
 #include "send.h"
 #include "msg.h"
@@ -153,13 +154,14 @@ static int mo_list(struct Client *client_p, struct Client *source_p, int parc, c
 	/* Let the user set it */
 	params.users_min = ConfigFileEntry.hide_channel_below_users;
 	params.users_max = INT_MAX;
+	params.operspy = 0;
 
 	if (parc > 1 && parv[1] != NULL && !IsChannelName(parv[1]))
 	{
 		args = LOCAL_COPY(parv[1]);
-		/* Make any specification cancel out defaults */
-		if (*args == '<')
-			params.users_min = 0;
+
+		/* Cancel out default minimum. */
+		params.users_min = 0;
 
 		for (i = 0; i < 2; i++)
 		{
@@ -188,6 +190,12 @@ static int mo_list(struct Client *client_p, struct Client *source_p, int parc, c
 				else
 					params.users_min = 0;
 			}
+			/* Only accept operspy as the first option. */
+			else if (*args == '!' && IsOperSpy(source_p) && i == 0)
+			{
+				params.operspy = 1;
+				report_operspy(source_p, "LIST", p);
+			}
 
 			if (EmptyString(p))
 				break;
@@ -249,6 +257,7 @@ static void safelist_client_instantiate(struct Client *client_p, struct ListClie
 	self->hash_indice = 0;
 	self->users_min = params->users_min;
 	self->users_max = params->users_max;
+	self->operspy = params->operspy;
 
 	client_p->localClient->safelist_data = self;
 
@@ -320,8 +329,8 @@ static void safelist_channel_named(struct Client *source_p, const char *name)
 	}
 
 	if (!SecretChannel(chptr) || IsMember(source_p, chptr))
-		sendto_one(source_p, form_str(RPL_LIST), me.name, source_p->name, chptr->chname,
-			   rb_dlink_list_length(&chptr->members),
+		sendto_one(source_p, form_str(RPL_LIST), me.name, source_p->name, "",
+			   chptr->chname, rb_dlink_list_length(&chptr->members),
 			   chptr->topic == NULL ? "" : chptr->topic);
 
 	sendto_one(source_p, form_str(RPL_LISTEND), me.name, source_p->name);
@@ -340,15 +349,17 @@ static void safelist_one_channel(struct Client *source_p, struct Channel *chptr)
 {
 	struct ListClient *safelist_data = source_p->localClient->safelist_data;
 
-	if (SecretChannel(chptr) && !IsMember(source_p, chptr))
+	if (SecretChannel(chptr) && !IsMember(source_p, chptr) && !safelist_data->operspy)
 		return;
 
 	if ((unsigned int)chptr->members.length < safelist_data->users_min
 	    || (unsigned int)chptr->members.length > safelist_data->users_max)
 		return;
 
-	sendto_one(source_p, form_str(RPL_LIST), me.name, source_p->name, chptr->chname,
-		   chptr->members.length, chptr->topic == NULL ? "" : chptr->topic);
+	sendto_one(source_p, form_str(RPL_LIST), me.name, source_p->name,
+		   (safelist_data->operspy && SecretChannel(chptr)) ? "!" : "",
+		   chptr->chname, rb_dlink_list_length(&chptr->members),
+		   chptr->topic == NULL ? "" : chptr->topic);
 }
 
 /*
diff --git a/src/messages.tab b/src/messages.tab
index 2572c81..28f413c 100644
--- a/src/messages.tab
+++ b/src/messages.tab
@@ -343,7 +343,7 @@ static  const char *  replies[] = {
 /* 319 RPL_WHOISCHANNELS, */    ":%s 319 %s %s :",
 /* 320 */      NULL,
 /* 321 RPL_LISTSTART, */        ":%s 321 %s Channel :Users  Name",
-/* 322 RPL_LIST, */             ":%s 322 %s %s %d :%s",
+/* 322 RPL_LIST, */             ":%s 322 %s %s%s %d :%s",
 /* 323 RPL_LISTEND, */          ":%s 323 %s :End of /LIST",
 /* 324 RPL_CHANNELMODEIS, */    ":%s 324 %s %s %s",
 /* 325 RPL_CHANNELMLOCKIS, */   ":%s 325 %s %s %s :is the current channel mode-lock",