]> jfr.im git - irc/rqf/shadowircd.git/blobdiff - src/s_user.c
Allow opers to see other users umodes with /mode <nick>.
[irc/rqf/shadowircd.git] / src / s_user.c
index ef413d514b5b2bbd4d8256322388b5bdda4203b6..f9984f40c1828a3c67e5144301a6c7a1f3d479fd 100644 (file)
  */
 
 #include "stdinc.h"
-#include "tools.h"
 #include "s_user.h"
 #include "channel.h"
 #include "class.h"
 #include "client.h"
 #include "common.h"
 #include "hash.h"
-#include "irc_string.h"
-#include "sprintf_irc.h"
+#include "match.h"
 #include "ircd.h"
 #include "listener.h"
 #include "msg.h"
 #include "numeric.h"
-#include "commio.h"
 #include "s_conf.h"
 #include "s_newconf.h"
-#include "s_log.h"
+#include "logger.h"
 #include "s_serv.h"
 #include "s_stats.h"
 #include "scache.h"
 #include "send.h"
 #include "supported.h"
 #include "whowas.h"
-#include "memory.h"
 #include "packet.h"
 #include "reject.h"
 #include "cache.h"
 #include "snomask.h"
 #include "blacklist.h"
 #include "substitution.h"
+#include "chmode.h"
 
 static void report_and_set_user_flags(struct Client *, struct ConfItem *);
 void user_welcome(struct Client *source_p);
 
-extern char *crypt();
-
 char umodebuf[128];
 
 static int orphaned_umodes = 0;
@@ -97,7 +92,7 @@ int user_modes[256] = {
        0,                      /* W */
        0,                      /* X */
        0,                      /* Y */
-       0,                      /* Z */
+       UMODE_SSLCLIENT,        /* Z */
        /* 0x5B */ 0, 0, 0, 0, 0, 0, /* 0x60 */
        UMODE_ADMIN,            /* a */
        0,                      /* b */
@@ -147,41 +142,41 @@ int user_modes[256] = {
 int
 show_lusers(struct Client *source_p)
 {
-       if(dlink_list_length(&lclient_list) > (unsigned long)MaxClientCount)
-               MaxClientCount = dlink_list_length(&lclient_list);
+       if(rb_dlink_list_length(&lclient_list) > (unsigned long)MaxClientCount)
+               MaxClientCount = rb_dlink_list_length(&lclient_list);
 
-       if((dlink_list_length(&lclient_list) + dlink_list_length(&serv_list)) >
+       if((rb_dlink_list_length(&lclient_list) + rb_dlink_list_length(&serv_list)) >
           (unsigned long)MaxConnectionCount)
-               MaxConnectionCount = dlink_list_length(&lclient_list) + 
-                                       dlink_list_length(&serv_list);
+               MaxConnectionCount = rb_dlink_list_length(&lclient_list) + 
+                                       rb_dlink_list_length(&serv_list);
 
        sendto_one_numeric(source_p, RPL_LUSERCLIENT, form_str(RPL_LUSERCLIENT),
                           (Count.total - Count.invisi),
-                          Count.invisi, dlink_list_length(&global_serv_list));
+                          Count.invisi, rb_dlink_list_length(&global_serv_list));
 
-       if(dlink_list_length(&oper_list) > 0)
+       if(rb_dlink_list_length(&oper_list) > 0)
                sendto_one_numeric(source_p, RPL_LUSEROP, 
-                                  form_str(RPL_LUSEROP), dlink_list_length(&oper_list));
+                                  form_str(RPL_LUSEROP), rb_dlink_list_length(&oper_list));
 
-       if(dlink_list_length(&unknown_list) > 0)
+       if(rb_dlink_list_length(&unknown_list) > 0)
                sendto_one_numeric(source_p, RPL_LUSERUNKNOWN, 
                                   form_str(RPL_LUSERUNKNOWN),
-                                  dlink_list_length(&unknown_list));
+                                  rb_dlink_list_length(&unknown_list));
 
-       if(dlink_list_length(&global_channel_list) > 0)
+       if(rb_dlink_list_length(&global_channel_list) > 0)
                sendto_one_numeric(source_p, RPL_LUSERCHANNELS, 
                                   form_str(RPL_LUSERCHANNELS),
-                                  dlink_list_length(&global_channel_list));
+                                  rb_dlink_list_length(&global_channel_list));
 
        sendto_one_numeric(source_p, RPL_LUSERME, form_str(RPL_LUSERME),
-                          dlink_list_length(&lclient_list),
-                          dlink_list_length(&serv_list));
+                          rb_dlink_list_length(&lclient_list),
+                          rb_dlink_list_length(&serv_list));
 
        sendto_one_numeric(source_p, RPL_LOCALUSERS, 
                           form_str(RPL_LOCALUSERS),
-                          dlink_list_length(&lclient_list),
+                          rb_dlink_list_length(&lclient_list),
                           Count.max_loc,
-                          dlink_list_length(&lclient_list),
+                          rb_dlink_list_length(&lclient_list),
                           Count.max_loc);
 
        sendto_one_numeric(source_p, RPL_GLOBALUSERS, form_str(RPL_GLOBALUSERS),
@@ -223,7 +218,7 @@ show_lusers(struct Client *source_p)
 int
 register_local_user(struct Client *client_p, struct Client *source_p, const char *username)
 {
-       struct ConfItem *aconf;
+       struct ConfItem *aconf, *xconf;
        struct User *user = source_p->user;
        char tmpstr2[IRCD_BUFSIZE];
        char ipaddr[HOSTIPLEN];
@@ -250,21 +245,21 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                        source_p->flags |= FLAGS_PINGSENT;
                        return -1;
                }
-               if(!(source_p->flags2 & FLAGS2_PING_COOKIE))
+               if(!(source_p->flags & FLAGS_PING_COOKIE))
                {
                        return -1;
                }
        }
 
        /* hasnt finished client cap negotiation */
-       if(source_p->flags2 & FLAGS2_CLICAP)
+       if(source_p->flags & FLAGS_CLICAP)
                return -1;
 
        /* still has DNSbls to validate against */
-       if(dlink_list_length(&source_p->preClient->dnsbl_queries) > 0)
+       if(rb_dlink_list_length(&source_p->preClient->dnsbl_queries) > 0)
                return -1;
 
-       client_p->localClient->last = CurrentTime;
+       client_p->localClient->last = rb_current_time();
        /* Straight up the maximum rate of flooding... */
        source_p->localClient->allow_read = MAX_FLOOD_BURST;
 
@@ -293,22 +288,21 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
        /* Apply nick override */
        if(*source_p->preClient->spoofnick)
        {
+               char note[NICKLEN + 10];
+
                del_from_client_hash(source_p->name, source_p);
-               strlcpy(source_p->name, source_p->preClient->spoofnick, NICKLEN + 1);
+               rb_strlcpy(source_p->name, source_p->preClient->spoofnick, NICKLEN + 1);
                add_to_client_hash(source_p->name, source_p);
-               comm_note(source_p->localClient->fd, "Nick: %s", source_p->name);
+
+               rb_snprintf(note, NICKLEN + 10, "Nick: %s", source_p->name);
+               rb_note(source_p->localClient->F, note);
        }
 
        if(!valid_hostname(source_p->host))
        {
                sendto_one_notice(source_p, ":*** Notice -- You have an illegal character in your hostname");
 
-               strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
-
-#ifdef IPV6
-               if(ConfigFileEntry.dot_in_ip6_addr == 1)
-                       strlcat(source_p->host, ".", sizeof(source_p->host));
-#endif
+               rb_strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
        }
  
 
@@ -320,6 +314,14 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                return (CLIENT_EXITED);
        }
 
+       if(IsConfSSLNeeded(aconf) && !IsSSL(source_p))
+       {
+               ServerStats.is_ref++;
+               sendto_one_notice(source_p, ":*** Notice -- You need to use SSL/TLS to use this server");
+               exit_client(client_p, source_p, &me, "Use SSL/TLS");
+               return (CLIENT_EXITED);
+       }
+
        if(!IsGotId(source_p))
        {
                const char *p;
@@ -327,7 +329,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
 
                if(IsNeedIdentd(aconf))
                {
-                       ServerStats->is_ref++;
+                       ServerStats.is_ref++;
                        sendto_one_notice(source_p, ":*** Notice -- You need to install identd to use this server");
                        exit_client(client_p, source_p, &me, "Install identd");
                        return (CLIENT_EXITED);
@@ -354,7 +356,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
 
        if(IsNeedSasl(aconf) && !*user->suser)
        {
-               ServerStats->is_ref++;
+               ServerStats.is_ref++;
                sendto_one_notice(source_p, ":*** Notice -- You need to identify via SASL to use this server");
                exit_client(client_p, source_p, &me, "SASL access only");
                return (CLIENT_EXITED);
@@ -368,13 +370,13 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                if(EmptyString(source_p->localClient->passwd))
                        encr = "";
                else if(IsConfEncrypted(aconf))
-                       encr = crypt(source_p->localClient->passwd, aconf->passwd);
+                       encr = rb_crypt(source_p->localClient->passwd, aconf->passwd);
                else
                        encr = source_p->localClient->passwd;
 
                if(strcmp(encr, aconf->passwd))
                {
-                       ServerStats->is_ref++;
+                       ServerStats.is_ref++;
                        sendto_one(source_p, form_str(ERR_PASSWDMISMATCH), me.name, source_p->name);
                        exit_client(client_p, source_p, &me, "Bad Password");
                        return (CLIENT_EXITED);
@@ -385,7 +387,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                if(source_p->localClient->passwd)
                {
                        memset(source_p->localClient->passwd, 0, strlen(source_p->localClient->passwd));
-                       MyFree(source_p->localClient->passwd);
+                       rb_free(source_p->localClient->passwd);
                        source_p->localClient->passwd = NULL;
                }
        }
@@ -402,23 +404,23 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
         *   -Taner
         */
        /* Except "F:" clients */
-       if(dlink_list_length(&lclient_list) >=
-           (unsigned long)GlobalSetOptions.maxclients && !IsExemptLimits(source_p))
+       if(rb_dlink_list_length(&lclient_list) >=
+           (unsigned long)GlobalSetOptions.maxclients && !IsConfExemptLimits(aconf))
        {
                sendto_realops_snomask(SNO_FULL, L_ALL,
                                     "Too many clients, rejecting %s[%s].", source_p->name, source_p->host);
 
-               ServerStats->is_ref++;
+               ServerStats.is_ref++;
                exit_client(client_p, source_p, &me, "Sorry, server is full - try later");
                return (CLIENT_EXITED);
        }
 
        /* kline exemption extends to xline too */
        if(!IsExemptKline(source_p) &&
-          find_xline(source_p->info, 1) != NULL)
+          (xconf = find_xline(source_p->info, 1)) != NULL)
        {
-               ServerStats->is_ref++;
-               add_reject(source_p);
+               ServerStats.is_ref++;
+               add_reject(source_p, xconf->name, NULL);
                exit_client(client_p, source_p, &me, "Bad user info");
                return CLIENT_EXITED;
        }
@@ -431,7 +433,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                                        source_p->sockhost, source_p->preClient->dnsbl_listed->host);
                else
                {
-                       dlink_list varlist = { NULL, NULL, 0 };
+                       rb_dlink_list varlist = { NULL, NULL, 0 };
 
                        substitution_append_var(&varlist, "nick", source_p->name);
                        substitution_append_var(&varlist, "ip", source_p->sockhost);
@@ -439,7 +441,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                        substitution_append_var(&varlist, "dnsbl-host", source_p->preClient->dnsbl_listed->host);
                        substitution_append_var(&varlist, "network-name", ServerInfo.network_name);
 
-                       ServerStats->is_ref++;
+                       ServerStats.is_ref++;
 
                        sendto_one(source_p, form_str(ERR_YOUREBANNEDCREEP),
                                        me.name, source_p->name,
@@ -450,7 +452,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                        sendto_one_notice(source_p, ":*** Your IP address %s is listed in %s",
                                        source_p->sockhost, source_p->preClient->dnsbl_listed->host);
                        source_p->preClient->dnsbl_listed->hits++;
-                       add_reject(source_p);
+                       add_reject(source_p, NULL, NULL);
                        exit_client(client_p, source_p, &me, "*** Banned (DNS blacklist)");
                        return CLIENT_EXITED;
                }
@@ -463,10 +465,10 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                sendto_realops_snomask(SNO_REJ, L_ALL,
                                     "Invalid username: %s (%s@%s)",
                                     source_p->name, source_p->username, source_p->host);
-               ServerStats->is_ref++;
+               ServerStats.is_ref++;
                sendto_one_notice(source_p, ":*** Your username is invalid. Please make sure that your username contains "
                                            "only alphanumeric characters.");
-               ircsprintf(tmpstr2, "Invalid username [%s]", source_p->username);
+               rb_sprintf(tmpstr2, "Invalid username [%s]", source_p->username);
                exit_client(client_p, source_p, &me, tmpstr2);
                return (CLIENT_EXITED);
        }
@@ -474,14 +476,14 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
        /* end of valid user name check */
 
        /* Store original hostname -- jilles */
-       strlcpy(source_p->orighost, source_p->host, HOSTLEN + 1);
+       rb_strlcpy(source_p->orighost, source_p->host, HOSTLEN + 1);
 
        /* Spoof user@host */
        if(*source_p->preClient->spoofuser)
-               strlcpy(source_p->username, source_p->preClient->spoofuser, USERLEN + 1);
+               rb_strlcpy(source_p->username, source_p->preClient->spoofuser, USERLEN + 1);
        if(*source_p->preClient->spoofhost)
        {
-               strlcpy(source_p->host, source_p->preClient->spoofhost, HOSTLEN + 1);
+               rb_strlcpy(source_p->host, source_p->preClient->spoofhost, HOSTLEN + 1);
                if (irccmp(source_p->host, source_p->orighost))
                        SetDynSpoof(source_p);
        }
@@ -498,7 +500,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
        /* To avoid inconsistencies, do not abort the registration
         * starting from this point -- jilles
         */
-       inetntop_sock((struct sockaddr *)&source_p->localClient->ip, ipaddr, sizeof(ipaddr));
+       rb_inet_ntop_sock((struct sockaddr *)&source_p->localClient->ip, ipaddr, sizeof(ipaddr));
 
        sendto_realops_snomask(SNO_CCONN, L_ALL,
                             "Client connecting: %s (%s@%s) [%s] {%s} [%s]",
@@ -526,16 +528,18 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
                add_to_id_hash(source_p->id, source_p);
        }
 
+       if (IsSSL(source_p))
+               source_p->umodes |= UMODE_SSLCLIENT;
+
        if (source_p->umodes & UMODE_INVISIBLE)
                Count.invisi++;
 
        s_assert(!IsClient(source_p));
-       del_unknown_ip(source_p);
-       dlinkMoveNode(&source_p->localClient->tnode, &unknown_list, &lclient_list);
+       rb_dlinkMoveNode(&source_p->localClient->tnode, &unknown_list, &lclient_list);
        SetClient(source_p);
 
        source_p->servptr = &me;
-       dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->users);
+       rb_dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->users);
 
        /* Increment our total user count here */
        if(++Count.total > Count.max_tot)
@@ -547,9 +551,9 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
 
        s_assert(source_p->localClient != NULL);
 
-       if(dlink_list_length(&lclient_list) > (unsigned long)Count.max_loc)
+       if(rb_dlink_list_length(&lclient_list) > (unsigned long)Count.max_loc)
        {
-               Count.max_loc = dlink_list_length(&lclient_list);
+               Count.max_loc = rb_dlink_list_length(&lclient_list);
                if(!(Count.max_loc % 10))
                        sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                             "New Max Local Clients: %d", Count.max_loc);
@@ -584,6 +588,7 @@ introduce_client(struct Client *client_p, struct Client *source_p, struct User *
        char *p;
        hook_data_umode_changed hdata;
        hook_data_client hdata2;
+       char sockhost[HOSTLEN];
 
        if(MyClient(source_p))
                send_umode(source_p, source_p, 0, 0, ubuf);
@@ -596,70 +601,48 @@ introduce_client(struct Client *client_p, struct Client *source_p, struct User *
                ubuf[1] = '\0';
        }
 
-       /* if it has an ID, introduce it with its id to TS6 servers,
-        * otherwise introduce it normally to all.
-        */
-       if(has_id(source_p))
+       s_assert(has_id(source_p));
+
+       if(source_p->sockhost[0] == ':')
        {
-               char sockhost[HOSTLEN];
-               if(source_p->sockhost[0] == ':')
-               {
-                       sockhost[0] = '0';
-                       sockhost[1] = '\0';
-                       strlcat(sockhost, source_p->sockhost, sizeof(sockhost));
-               } else
-                       strcpy(sockhost, source_p->sockhost);
+               sockhost[0] = '0';
+               sockhost[1] = '\0';
+               rb_strlcat(sockhost, source_p->sockhost, sizeof(sockhost));
+       } else
+               strcpy(sockhost, source_p->sockhost);
                
-               if (use_euid)
-                       sendto_server(client_p, NULL, CAP_EUID | CAP_TS6, NOCAPS,
-                                       ":%s EUID %s %d %ld %s %s %s %s %s %s %s :%s",
-                                       source_p->servptr->id, nick,
-                                       source_p->hopcount + 1,
-                                       (long) source_p->tsinfo, ubuf,
-                                       source_p->username, source_p->host,
-                                       IsIPSpoof(source_p) ? "0" : sockhost,
-                                       source_p->id,
-                                       IsDynSpoof(source_p) ? source_p->orighost : "*",
-                                       EmptyString(source_p->user->suser) ? "*" : source_p->user->suser,
-                                       source_p->info);
-
-               sendto_server(client_p, NULL, CAP_TS6, use_euid ? CAP_EUID : NOCAPS,
-                             ":%s UID %s %d %ld %s %s %s %s %s :%s",
-                             source_p->servptr->id, nick,
-                             source_p->hopcount + 1,
-                             (long) source_p->tsinfo, ubuf,
-                             source_p->username, source_p->host,
-                             IsIPSpoof(source_p) ? "0" : sockhost,
-                             source_p->id, source_p->info);
-
-               sendto_server(client_p, NULL, NOCAPS, CAP_TS6,
-                             "NICK %s %d %ld %s %s %s %s :%s",
-                             nick, source_p->hopcount + 1,
-                             (long) source_p->tsinfo,
-                             ubuf, source_p->username, source_p->host,
-                             source_p->servptr->name, source_p->info);
-       }
-       else
-               sendto_server(client_p, NULL, NOCAPS, NOCAPS,
-                             "NICK %s %d %ld %s %s %s %s :%s",
-                             nick, source_p->hopcount + 1,
-                             (long) source_p->tsinfo,
-                             ubuf, source_p->username, source_p->host,
-                             source_p->servptr->name, source_p->info);
+       if (use_euid)
+               sendto_server(client_p, NULL, CAP_EUID | CAP_TS6, NOCAPS,
+                               ":%s EUID %s %d %ld %s %s %s %s %s %s %s :%s",
+                               source_p->servptr->id, nick,
+                               source_p->hopcount + 1,
+                               (long) source_p->tsinfo, ubuf,
+                               source_p->username, source_p->host,
+                               IsIPSpoof(source_p) ? "0" : sockhost,
+                               source_p->id,
+                               IsDynSpoof(source_p) ? source_p->orighost : "*",
+                               EmptyString(source_p->user->suser) ? "*" : source_p->user->suser,
+                               source_p->info);
+
+       sendto_server(client_p, NULL, CAP_TS6, use_euid ? CAP_EUID : NOCAPS,
+                     ":%s UID %s %d %ld %s %s %s %s %s :%s",
+                     source_p->servptr->id, nick,
+                     source_p->hopcount + 1,
+                     (long) source_p->tsinfo, ubuf,
+                     source_p->username, source_p->host,
+                     IsIPSpoof(source_p) ? "0" : sockhost,
+                     source_p->id, source_p->info);
 
        if (IsDynSpoof(source_p))
        {
                sendto_server(client_p, NULL, CAP_TS6, use_euid ? CAP_EUID : NOCAPS, ":%s ENCAP * REALHOST %s",
                                use_id(source_p), source_p->orighost);
-               sendto_server(client_p, NULL, NOCAPS, CAP_TS6, ":%s ENCAP * REALHOST %s",
-                               source_p->name, source_p->orighost);
        }
+
        if (!EmptyString(source_p->user->suser))
        {
                sendto_server(client_p, NULL, CAP_TS6, use_euid ? CAP_EUID : NOCAPS, ":%s ENCAP * LOGIN %s",
                                use_id(source_p), source_p->user->suser);
-               sendto_server(client_p, NULL, NOCAPS, CAP_TS6, ":%s ENCAP * LOGIN %s",
-                               source_p->name, source_p->user->suser);
        }
 
        if(MyConnect(source_p) && source_p->localClient->passwd)
@@ -674,14 +657,24 @@ introduce_client(struct Client *client_p, struct Client *source_p, struct User *
                        else
                                identifyservice_p = NULL;
                        if (identifyservice_p != NULL)
-                               sendto_one(identifyservice_p, ":%s PRIVMSG %s :%s %s",
-                                               get_id(source_p, identifyservice_p),
-                                               ConfigFileEntry.identifyservice,
-                                               ConfigFileEntry.identifycommand,
-                                               source_p->localClient->passwd);
+                       {
+                               if (!EmptyString(source_p->localClient->auth_user))
+                                       sendto_one(identifyservice_p, ":%s PRIVMSG %s :%s %s %s",
+                                                       get_id(source_p, identifyservice_p),
+                                                       ConfigFileEntry.identifyservice,
+                                                       ConfigFileEntry.identifycommand,
+                                                       source_p->localClient->auth_user,
+                                                       source_p->localClient->passwd);
+                               else
+                                       sendto_one(identifyservice_p, ":%s PRIVMSG %s :%s %s",
+                                                       get_id(source_p, identifyservice_p),
+                                                       ConfigFileEntry.identifyservice,
+                                                       ConfigFileEntry.identifycommand,
+                                                       source_p->localClient->passwd);
+                       }
                }
                memset(source_p->localClient->passwd, 0, strlen(source_p->localClient->passwd));
-               MyFree(source_p->localClient->passwd);
+               rb_free(source_p->localClient->passwd);
                source_p->localClient->passwd = NULL;
        }
 
@@ -809,75 +802,82 @@ report_and_set_user_flags(struct Client *source_p, struct ConfItem *aconf)
        /* If this user is being spoofed, tell them so */
        if(IsConfDoSpoofIp(aconf))
        {
-               sendto_one_notice(source_p, ":*** Spoofing your IP. congrats.");
+               sendto_one_notice(source_p, ":*** Spoofing your IP");
        }
 
        /* If this user is in the exception class, Set it "E lined" */
        if(IsConfExemptKline(aconf))
        {
                SetExemptKline(source_p);
-               sendto_one_notice(source_p, ":*** You are exempt from K/D/G/X lines. congrats.");
-       }
-
-       if(IsConfExemptGline(aconf))
-       {
-               SetExemptGline(source_p);
-
-               /* dont send both a kline and gline exempt notice */
-               if(!IsConfExemptKline(aconf))
-                       sendto_one_notice(source_p, ":*** You are exempt from G lines.");
+               sendto_one_notice(source_p, ":*** You are exempt from K/X lines");
        }
 
        if(IsConfExemptDNSBL(aconf))
                /* kline exempt implies this, don't send both */
                if(!IsConfExemptKline(aconf))
-                       sendto_one_notice(source_p, ":*** You are exempt from DNS blacklists.");
+                       sendto_one_notice(source_p, ":*** You are exempt from DNS blacklists");
 
        /* If this user is exempt from user limits set it F lined" */
        if(IsConfExemptLimits(aconf))
        {
-               SetExemptLimits(source_p);
-               sendto_one_notice(source_p, "*** You are exempt from user limits. congrats.");
-       }
-
-       /* If this user is exempt from idle time outs */
-       if(IsConfIdlelined(aconf))
-       {
-               SetIdlelined(source_p);
-               sendto_one_notice(source_p, ":*** You are exempt from idle limits. congrats.");
+               sendto_one_notice(source_p, ":*** You are exempt from user limits");
        }
 
        if(IsConfExemptFlood(aconf))
        {
                SetExemptFlood(source_p);
-               sendto_one_notice(source_p, ":*** You are exempt from flood limits.");
+               sendto_one_notice(source_p, ":*** You are exempt from flood limits");
        }
 
        if(IsConfExemptSpambot(aconf))
        {
                SetExemptSpambot(source_p);
-               sendto_one_notice(source_p, ":*** You are exempt from spambot checks.");
+               sendto_one_notice(source_p, ":*** You are exempt from spambot checks");
        }
 
        if(IsConfExemptJupe(aconf))
        {
                SetExemptJupe(source_p);
-               sendto_one_notice(source_p, ":*** You are exempt from juped channel warnings.");
+               sendto_one_notice(source_p, ":*** You are exempt from juped channel warnings");
        }
 
        if(IsConfExemptResv(aconf))
        {
                SetExemptResv(source_p);
-               sendto_one_notice(source_p, ":*** You are exempt from resvs.");
+               sendto_one_notice(source_p, ":*** You are exempt from resvs");
        }
 
        if(IsConfExemptShide(aconf))
        {
                SetExemptShide(source_p);
-               sendto_one_notice(source_p, ":*** You are exempt from serverhiding.");
+               sendto_one_notice(source_p, ":*** You are exempt from serverhiding");
        }
 }
 
+static void
+show_other_user_mode(struct Client *source_p, struct Client *target_p)
+{
+       int i;
+       char buf[BUFSIZE];
+       char *m;
+
+       m = buf;
+       *m++ = '+';
+
+       for (i = 0; i < 128; i++) /* >= 127 is extended ascii */
+               if (target_p->umodes & user_modes[i])
+                       *m++ = (char) i;
+       *m = '\0';
+
+       if (MyConnect(target_p) && target_p->snomask != 0)
+               sendto_one_notice(source_p, ":Modes for %s are %s %s",
+                               target_p->name, buf,
+                               construct_snobuf(target_p->snomask));
+       else
+               sendto_one_notice(source_p, ":Modes for %s are %s",
+                               target_p->name, buf);
+}
+
 /*
  * user_mode - set get current users mode
  *
@@ -928,9 +928,12 @@ user_mode(struct Client *client_p, struct Client *source_p, int parc, const char
                return 0;
        }
 
-       if(source_p != target_p || target_p->from != source_p->from)
+       if(source_p != target_p)
        {
-               sendto_one(source_p, form_str(ERR_USERSDONTMATCH), me.name, source_p->name);
+               if (MyOper(source_p) && parc < 3)
+                       show_other_user_mode(source_p, target_p);
+               else
+                       sendto_one(source_p, form_str(ERR_USERSDONTMATCH), me.name, source_p->name);
                return 0;
        }
 
@@ -977,7 +980,7 @@ user_mode(struct Client *client_p, struct Client *source_p, int parc, const char
                                {
                                        ++Count.oper;
                                        SetOper(source_p);
-                                       dlinkAddAlloc(source_p, &oper_list);
+                                       rb_dlinkAddAlloc(source_p, &oper_list);
                                }
                        }
                        else
@@ -1003,13 +1006,15 @@ user_mode(struct Client *client_p, struct Client *source_p, int parc, const char
                                        }
                                        source_p->flags2 &= ~OPER_FLAGS;
 
-                                       MyFree(source_p->localClient->opername);
+                                       rb_free(source_p->localClient->opername);
                                        source_p->localClient->opername = NULL;
 
-                                       dlinkFindDestroy(source_p, &local_oper_list);
+                                       rb_dlinkFindDestroy(source_p, &local_oper_list);
+                                       privilegeset_unref(source_p->localClient->privset);
+                                       source_p->localClient->privset = NULL;
                                }
 
-                               dlinkFindDestroy(source_p, &oper_list);
+                               rb_dlinkFindDestroy(source_p, &oper_list);
                        }
                        break;
 
@@ -1019,6 +1024,7 @@ user_mode(struct Client *client_p, struct Client *source_p, int parc, const char
 
                /* can only be set on burst */
                case 'S':
+               case 'Z':
                case ' ':
                case '\n':
                case '\r':
@@ -1089,7 +1095,7 @@ user_mode(struct Client *client_p, struct Client *source_p, int parc, const char
 
        if(MyClient(source_p) && (source_p->snomask & SNO_NCHANGE) && !IsOperN(source_p))
        {
-               sendto_one_notice(source_p, ":*** You need oper and N flag for +s +n");
+               sendto_one_notice(source_p, ":*** You need oper and nick_changes flag for +s +n");
                source_p->snomask &= ~SNO_NCHANGE;      /* only tcm's really need this */
        }
 
@@ -1102,7 +1108,7 @@ user_mode(struct Client *client_p, struct Client *source_p, int parc, const char
        if(MyConnect(source_p) && (source_p->umodes & UMODE_ADMIN) &&
           (!IsOperAdmin(source_p) || IsOperHiddenAdmin(source_p)))
        {
-               sendto_one_notice(source_p, ":*** You need oper and A flag for +a");
+               sendto_one_notice(source_p, ":*** You need oper and admin flag for +a");
                source_p->umodes &= ~UMODE_ADMIN;
        }
 
@@ -1192,11 +1198,11 @@ send_umode_out(struct Client *client_p, struct Client *source_p, int old)
 {
        struct Client *target_p;
        char buf[BUFSIZE];
-       dlink_node *ptr;
+       rb_dlink_node *ptr;
 
        send_umode(NULL, source_p, old, 0, buf);
 
-       DLINK_FOREACH(ptr, serv_list.head)
+       RB_DLINK_FOREACH(ptr, serv_list.head)
        {
                target_p = ptr->data;
 
@@ -1226,7 +1232,7 @@ user_welcome(struct Client *source_p)
        sendto_one_numeric(source_p, RPL_YOURHOST, form_str(RPL_YOURHOST),
                   get_listener_name(source_p->localClient->listener), ircd_version);
        sendto_one_numeric(source_p, RPL_CREATED, form_str(RPL_CREATED), creation);
-       sendto_one_numeric(source_p, RPL_MYINFO, form_str(RPL_MYINFO), me.name, ircd_version, umodebuf);
+       sendto_one_numeric(source_p, RPL_MYINFO, form_str(RPL_MYINFO), me.name, ircd_version, umodebuf, cflagsmyinfo);
 
        show_isupport(source_p);
 
@@ -1290,10 +1296,11 @@ oper_up(struct Client *source_p, struct oper_conf *oper_p)
        SetExemptKline(source_p);
 
        source_p->flags2 |= oper_p->flags;
-       DupString(source_p->localClient->opername, oper_p->name);
+       source_p->localClient->opername = rb_strdup(oper_p->name);
+       source_p->localClient->privset = privilegeset_ref(oper_p->privset);
 
-       dlinkAddAlloc(source_p, &local_oper_list);
-       dlinkAddAlloc(source_p, &oper_list);
+       rb_dlinkAddAlloc(source_p, &local_oper_list);
+       rb_dlinkAddAlloc(source_p, &oper_list);
 
        if(IsOperAdmin(source_p) && !IsOperHiddenAdmin(source_p))
                source_p->umodes |= UMODE_ADMIN;
@@ -1317,7 +1324,8 @@ oper_up(struct Client *source_p, struct oper_conf *oper_p)
        sendto_one_numeric(source_p, RPL_SNOMASK, form_str(RPL_SNOMASK),
                   construct_snobuf(source_p->snomask));
        sendto_one(source_p, form_str(RPL_YOUREOPER), me.name, source_p->name);
-       sendto_one_notice(source_p, ":*** Oper privs are %s", get_oper_privs(oper_p->flags));
+       sendto_one_notice(source_p, ":*** Oper privilege set is %s", oper_p->privset->name);
+       sendto_one_notice(source_p, ":*** Oper privs are %s", oper_p->privset->privs);
        send_oper_motd(source_p);
 
        return (1);
@@ -1381,9 +1389,9 @@ construct_umodebuf(void)
 
 void
 change_nick_user_host(struct Client *target_p, const char *nick, const char *user,
-                     const char *host, int newts, char *format, ...)
+                     const char *host, int newts, const char *format, ...)
 {
-       dlink_node *ptr;
+       rb_dlink_node *ptr;
        struct Channel *chptr;
        struct membership *mscptr;
        int changed = irccmp(target_p->name, nick);
@@ -1411,7 +1419,7 @@ change_nick_user_host(struct Client *target_p,    const char *nick, const char *use
                                target_p->name, target_p->username, target_p->host,
                                reason);
 
-               DLINK_FOREACH(ptr, target_p->user->channel.head)
+               RB_DLINK_FOREACH(ptr, target_p->user->channel.head)
                {
                        mscptr = ptr->data;
                        chptr = mscptr->chptr;
@@ -1454,14 +1462,14 @@ change_nick_user_host(struct Client *target_p,  const char *nick, const char *use
                                target_p->host, nick);
        }
 
-       strlcpy(target_p->username, user, sizeof target_p->username);
-       strlcpy(target_p->host, host, sizeof target_p->host);
+       rb_strlcpy(target_p->username, user, sizeof target_p->username);
+       rb_strlcpy(target_p->host, host, sizeof target_p->host);
 
        if (changed)
                add_history(target_p, 1);
 
        del_from_client_hash(target_p->name, target_p);
-       strlcpy(target_p->name, nick, NICKLEN);
+       rb_strlcpy(target_p->name, nick, NICKLEN);
        add_to_client_hash(target_p->name, target_p);
 
        if(changed)