Some clang static analyzer fixes.

[irc/rqf/shadowircd.git] / modules / m_whois.c

diff --git a/modules/m_whois.c b/modules/m_whois.c
index ed0d79982d9645b87613c3d02f4402d6906c57c3..3fc8f127e9b74f77e4f573efc5612cf5d35e3152 100644 (file)
--- a/modules/m_whois.c
+++ b/modules/m_whois.c
@@ -21,7 +21,6 @@
  *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
  *  USA
  *
- *  $Id: m_whois.c 3536 2007-07-14 21:50:21Z jilles $
  */
 
 #include "stdinc.h"
@@ -318,7 +317,7 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 
        if(IsOper(target_p))
        {
-               if(md = user_metadata_find(target_p, "OPERSTRING"))
+               if((md = user_metadata_find(target_p, "OPERSTRING")) != NULL)
                        sendto_one_numeric(source_p, 313, "%s :%s", target_p->name, md->value);
                else
                        sendto_one_numeric(source_p, RPL_WHOISOPERATOR, form_str(RPL_WHOISOPERATOR),
@@ -326,7 +325,7 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
                                        IsService(target_p) ? ConfigFileEntry.servicestring :
                                        (IsAdmin(target_p) ? GlobalSetOptions.adminstring :
                                        GlobalSetOptions.operstring));
-               if(md = user_metadata_find(target_p, "SWHOIS"))
+               if((md = user_metadata_find(target_p, "SWHOIS")) != NULL)
                        sendto_one_numeric(source_p, 320, "%s :%s", target_p->name, md->value);
        }