From: Chris Porter <redacted>
Date: Mon, 20 Oct 2008 17:53:14 +0000 (+0100)
Subject: Improve nicklist performance.
X-Git-Url: https://jfr.im/git/irc/quakenet/qwebirc.git/commitdiff_plain/52090a1fd94e6880264f7a2518e3aa88b0919dd0

Improve nicklist performance.
Add nicklist manipulation (stage 1).
---

diff --git a/TODO.txt b/TODO.txt
index 4db38a5..35fa380 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -1,6 +1,8 @@
 sound
 padding
 prettify wizard
-double click -> query
 tab completion
 options for notices and stuff
+noscript
+@+ in nick shown in text
+hilight in query bug fix
\ No newline at end of file
diff --git a/js/irc/ircclient.js b/js/irc/ircclient.js
index 7004f22..23dc104 100644
--- a/js/irc/ircclient.js
+++ b/js/irc/ircclient.js
@@ -124,6 +124,16 @@ qwebirc.irc.IRCClient = new Class({
     
     nickchanentry.prefixes = prefixes.join("");
   },
+  stripPrefix: function(nick) {
+    var l = nick.charAt(0);
+    if(!l)
+      return nick;
+      
+    if(this.prefixes.indexOf(l) != -1)
+      return nick.substring(1);
+      
+    return nick;
+  },
   removePrefix: function(nickchanentry, prefix) {
     nickchanentry.prefixes = nickchanentry.prefixes.replaceAll(prefix, "");
   },
diff --git a/js/jslib.js b/js/jslib.js
index 07a7e74..63281a3 100644
--- a/js/jslib.js
+++ b/js/jslib.js
@@ -139,4 +139,12 @@ RegExp.escape = function(text) {
   }
   
   return text.replace(arguments.callee.sRE, '\\$1');
+}
+
+qwebirc.ui.insertAt = function(position, parent, element) {
+  if(!parent.childNodes || (position >= parent.childNodes.length)) {
+    parent.appendChild(element);
+  } else {
+    parent.insertBefore(element, parent.childNodes[position]);
+  }
 }
\ No newline at end of file
diff --git a/js/ui/baseuiwindow.js b/js/ui/baseuiwindow.js
index 82c5af7..ded43fd 100644
--- a/js/ui/baseuiwindow.js
+++ b/js/ui/baseuiwindow.js
@@ -16,6 +16,7 @@ qwebirc.ui.Window = new Class({
     this.scrolltimer = null;
     this.commandhistory = this.parentObject.commandhistory;
     this.scrolleddown = true;
+    this.lastNickHash = {};
     //new CommandHistory();
   },
   updateNickList: function(nicks) {
@@ -124,6 +125,32 @@ qwebirc.ui.Window = new Class({
       this.scrolltimer = null;
     }
   },
+  updateNickList: function(nicks) {
+    var nickHash = {};
+    var added = [];
+    var lnh = this.lastNickHash;
+    
+    for(var i=0;i<nicks.length;i++) {
+      var n = nicks[i];
+      var l = lnh[n];
+      if(!l) {
+        l = this.nickListAdd(n, i);
+        if(!l)
+          l = 1;
+      }
+      nickHash[n] = l;
+    }
+    
+    for(var k in lnh)
+      if(!nickHash[k])
+        this.nickListRemove(k, lnh[k]);
+        
+    this.lastNickHash = nickHash;
+  },
+  nickListAdd: function(position, nick) {
+  },
+  nickListRemove: function(nick, stored) {
+  },
   historyExec: function(line) {
     this.commandhistory.addLine(line);
     this.client.exec(line);
diff --git a/js/ui/qui.js b/js/ui/qui.js
index 676029c..967e57f 100644
--- a/js/ui/qui.js
+++ b/js/ui/qui.js
@@ -196,6 +196,7 @@ qwebirc.ui.QUI.Window = new Class({
 
     this.tab = new Element("a", {"href": "#"});
     this.tab.addClass("tab");
+    this.tab.addEvent("focus", this.tab.blur);
     parentObject.tabs.appendChild(this.tab);
     
     this.tab.appendText(name);
@@ -216,7 +217,7 @@ qwebirc.ui.QUI.Window = new Class({
 
         this.close();
       }.bind(this));
-
+      
       this.tab.appendChild(tabclose);
     }
 
@@ -235,9 +236,16 @@ qwebirc.ui.QUI.Window = new Class({
       this.topic.set("html", "&nbsp;");
       this.parentObject.qjsui.applyClasses("topic", this.topic);
       
+      this.prevNick = null;
       this.nicklist = new Element("div");
       this.nicklist.addClass("nicklist");
       this.nicklist.addClass("tab-invisible");
+      this.nicklist.addEvent("click", function(x) {
+        if(this.prevNick) {
+          this.prevNick.removeClass("selected");
+          this.prevNick = null;
+        }
+      }.bind(this));
       this.parentObject.qjsui.applyClasses("nicklist", this.nicklist);
     }
     
@@ -254,18 +262,33 @@ qwebirc.ui.QUI.Window = new Class({
     if(this.scrolleddown)
       this.scrollToBottom();
   },
-  updateNickList: function(nicks) {
-    this.parent(nicks);
+  nickListAdd: function(nick, position) {
+    var e = new Element("a");
+    qwebirc.ui.insertAt(position, this.nicklist, e);
     
-    var n = this.nicklist;
-    while(n.firstChild)
-      n.removeChild(n.firstChild);
-
-    nicks.each(function(nick) {
-      var e = new Element("div");
-      n.appendChild(e);
-      e.appendChild(document.createTextNode(nick));
-    });
+    e.href = "#";
+    e.appendChild(document.createTextNode(nick));
+    
+    e.realNick = this.client.stripPrefix(nick);
+    
+    e.addEvent("click", function(x) {
+      if(this.prevNick)
+        this.prevNick.removeClass("selected");
+      this.prevNick = e;
+      e.addClass("selected");
+      new Event(x).stop();
+    }.bind(this));
+    e.addEvent("dblclick", function(x) {
+      new Event(x).stop();
+      this.client.exec("/QUERY " + e.realNick);
+    }.bind(this));
+    
+    e.addEvent("focus", e.blur);
+    
+    return e;
+  },
+  nickListRemove: function(nick, stored) {
+    this.nicklist.removeChild(stored);
   },
   updateTopic: function(topic) {
     var t = this.topic;
diff --git a/static/css/qui.css b/static/css/qui.css
index 53d05ec..f62ed8f 100644
--- a/static/css/qui.css
+++ b/static/css/qui.css
@@ -84,19 +84,6 @@ body {
   background: #f2f0ff;
 }
 
-.qwebirc-qui .nicklist {
-  border-left: 1px solid #c8d2dc;
-  position: absolute;
-  top: 0px;
-  right: 0px;
-  width: 125px;
-  overflow: auto;
-  background: #f2f0ff;
-  color: black;
-  font-family: Verdana, sans-serif;
-  font-size: 0.7em;
-}
-
 .qwebirc-qui .tabbar {
   border-bottom: 1px solid #c3cee0;
   background: #e2ecf9;
@@ -131,11 +118,11 @@ body {
 }
 
 .qwebirc-qui .topic .emptytopic {
-  color: grey;
+  color: gray;
 }
 
 .qwebirc-qui .topic {
-  color: grey;
+  color: gray;
   font-family: Verdana, sans-serif;
   padding-left: 5px;
   font-size: 0.7em;
@@ -205,3 +192,36 @@ body {
 .qwebirc-qui a.tab-hilight-us {
   color: red;
 }
+
+.qwebirc-qui .nicklist {
+  border-left: 1px solid #c8d2dc;
+  position: absolute;
+  top: 0px;
+  right: 0px;
+  width: 125px;
+  overflow: auto;
+  background: #f2f0ff;
+  color: black;
+  font-family: Verdana, sans-serif;
+  font-size: 0.7em;
+}
+
+.qwebirc-qui .nicklist a {
+  display: block;
+  color: black;
+  text-decoration: none;
+  cursor: default;
+  border-top: 1px solid #f2f0ff;
+  border-bottom: 1px solid #f2f0ff;
+  padding-left: 1px;
+}
+
+.qwebirc-qui .nicklist a.selected {
+  display: block;
+  color: black;
+  background: white;
+  text-decoration: none;
+  border-top: #c8d2dc 1px solid;
+  border-bottom: #c8d2dc 1px solid;
+  cursor: default;
+}
\ No newline at end of file