From: Thomas Sader <redacted>
Date: Sun, 16 Feb 2014 13:59:24 +0000 (+0100)
Subject: Fix a potential invalid memory access in iptobase64.
X-Git-Url: https://jfr.im/git/irc/quakenet/newserv.git/commitdiff_plain/c9cf3e857e2af7f75ae058c71aa893e83f0f3f23

Fix a potential invalid memory access in iptobase64.
---

diff --git a/lib/irc_ipv6.c b/lib/irc_ipv6.c
index ba6817e1..1be9d40d 100644
--- a/lib/irc_ipv6.c
+++ b/lib/irc_ipv6.c
@@ -440,7 +440,7 @@ const char* iptobase64(char* buf, const struct irc_in_addr* addr, unsigned int c
 
     assert(count >= 25);
     /* Can start by printing out the leading non-zero parts. */
-    for (ii = 0; (addr->in6_16[ii]) && (ii < 8); ++ii) {
+    for (ii = 0; (ii < 8) && (addr->in6_16[ii]); ++ii) {
       inttobase64(output, ntohs(addr->in6_16[ii]), 3);
       output += 3;
     }