From: Chris Porter <redacted>
Date: Sat, 26 Jun 2010 01:05:38 +0000 (+0000)
Subject: NOPERSERV: fix existence of command name information disclosure by doing /msg N help... 
X-Git-Url: https://jfr.im/git/irc/quakenet/newserv.git/commitdiff_plain/be515900ba65f8fbd397421d3b46bb0595156b14

NOPERSERV: fix existence of command name information disclosure by doing /msg N help <possible command>
---

diff --git a/noperserv/noperserv_hooks.c b/noperserv/noperserv_hooks.c
index 1a09a120..3df5e873 100644
--- a/noperserv/noperserv_hooks.c
+++ b/noperserv/noperserv_hooks.c
@@ -452,13 +452,8 @@ int noperserv_help(void *sender, int cargc, char **cargv) {
     return CMD_USAGE;
 
   cmd = findcommandintree(controlcmds, cargv[0], 1);
-  if(!cmd) {
-    controlreply(np, "Unknown command.");
-    return CMD_ERROR;
-  }
-  
-  if(!noperserv_policy_command_permitted(cmd->level, np)) {
-    controlreply(np, "Access denied.");
+  if(!cmd || !noperserv_policy_command_permitted(cmd->level, np)) {
+    controlreply(np, "Unknown command or access denied.");
     return CMD_ERROR;
   }