]> jfr.im git - irc/evilnet/x3.git/blobdiff - src/chanserv.c
Author:
[irc/evilnet/x3.git] / src / chanserv.c
index 7018a9942b3bb881f7a360e5b5cb01fb5475ca51..4518a937ff3c7dfdc8adb40efb1d9e8c264caf2a 100644 (file)
@@ -1,7 +1,7 @@
 /* chanserv.c - Channel service bot
  * Copyright 2000-2004 srvx Development Team
  *
- * This file is part of srvx.
+ * This file is part of x3.
  *
  * srvx is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -131,9 +131,9 @@ static const struct message_entry msgtab[] = {
 
 /* Do-not-register channels */
     { "CSMSG_NOT_DNR", "$b%s$b is not a valid channel name or *account." },
-    { "CSMSG_DNR_SEARCH_RESULTS", "The following do-not-registers were found:" },
-    { "CSMSG_DNR_INFO", "$b%s$b is do-not-register (by $b%s$b): %s" },
-    { "CSMSG_DNR_INFO_SET", "$b%s$b is do-not-register (set %s by $b%s$b): %s" },
+    { "CSMSG_DNR_SEARCH_RESULTS", "$bDo-Not-Register Channels$b" },
+    { "CSMSG_DNR_INFO", "$b%s$b (set by $b%s$b): %s" },
+    { "CSMSG_DNR_INFO_SET", "$b%s$b (set %s ago by $b%s$b): %s" },
     { "CSMSG_MORE_DNRS", "%d more do-not-register entries skipped." },
     { "CSMSG_DNR_CHANNEL", "Only network staff may register $b%s$b." },
     { "CSMSG_DNR_CHANNEL_MOVE", "Only network staff may move $b%s$b." },
@@ -184,13 +184,13 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_DELETED_YOU", "Your $b%d$b access has been deleted from $b%s$b." },
 
 /* User management */
-    { "CSMSG_ADDED_USER", "Added %s to the %s user list with access %d." },
+    { "CSMSG_ADDED_USER", "Added %s to the %s user list with access %s (%d)." },
     { "CSMSG_DELETED_USER", "Deleted %s (with access %d) from the %s user list." },
     { "CSMSG_BAD_RANGE", "Invalid access range; minimum (%d) must be greater than maximum (%d)." },
     { "CSMSG_DELETED_USERS", "Deleted accounts matching $b%s$b with access from $b%d$b to $b%d$b from the %s user list." },
     { "CSMSG_TRIMMED_USERS", "Trimmed $b%d users$b with access from %d to %d from the %s user list who were inactive for at least %s." },
-    { "CSMSG_INCORRECT_ACCESS", "%s has access $b%d$b, not %s." },
-    { "CSMSG_USER_EXISTS", "%s is already on the $b%s$b user list (with access %d)." },
+    { "CSMSG_INCORRECT_ACCESS", "%s has access $b%s$b, not %s." },
+    { "CSMSG_USER_EXISTS", "%s is already on the $b%s$b user list (with %s access)." },
     { "CSMSG_CANNOT_TRIM", "You must include a minimum inactivity duration of at least 60 seconds to trim." },
 
     { "CSMSG_NO_SELF_CLVL", "You cannot change your own access." },
@@ -228,7 +228,7 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_TOPIC_SET", "Topic is now '%s'." },
     { "CSMSG_NO_TOPIC", "$b%s$b does not have a default topic." },
     { "CSMSG_TOPICMASK_CONFLICT1", "I do not know how to make that topic work with the current topic mask in $b%s$b, which is: %s" },
-    { "CSMSG_TOPICMASK_CONFLICT2", "Please make sure your topic at most %d characters and matches the topic mask pattern." },
+    { "CSMSG_TOPICMASK_CONFLICT2", "Please make sure your topic is at most %d characters and matches the topic mask pattern." },
     { "CSMSG_TOPIC_LOCKED", "The %s topic is locked." },
     { "CSMSG_MASK_BUT_NO_TOPIC", "Warning: $b%s$b does not have a default topic, but you just set the topic mask." },
     { "CSMSG_TOPIC_MISMATCH", "Warning: The default topic for $b%s$b does not match the topic mask; changing it anyway." },
@@ -242,9 +242,11 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_CONFIRM_DEFAULTS", "To reset %s's settings to the defaults, you must use 'set defaults %s'." },
     { "CSMSG_SETTINGS_DEFAULTED", "All settings for %s have been reset to default values." },
     { "CSMSG_BAD_SETLEVEL", "You cannot change any setting to above your level." },
+    /*
     { "CSMSG_BAD_GIVEVOICE", "You cannot change GiveVoice to above GiveHalfOps (%d)." },
     { "CSMSG_BAD_GIVEHOPS", "You cannot change GiveHalfOps to below GiveOps (%d)." },
     { "CSMSG_BAD_GIVEOPS", "You cannot change GiveOps to below GiveVoice (%d)." },
+    */
     { "CSMSG_BAD_SETTERS", "You cannot change Setters to above your level." },
     { "CSMSG_INVALID_MODE_LOCK", "$b%s$b is an invalid mode lock." },
     { "CSMSG_INVALID_NUMERIC",   "$b%d$b is not a valid choice.  Choose one:" },
@@ -257,13 +259,17 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_SET_DYNLIMIT",      "$bDynLimit    $b %s" },
     { "CSMSG_SET_OFFCHANNEL",    "$bOffChannel  $b %s" },
     { "CSMSG_SET_USERINFO",      "$bUserInfo    $b %d" },
+    /*
     { "CSMSG_SET_GIVE_VOICE",    "$bGiveVoice   $b %d" },
     { "CSMSG_SET_GIVE_HALFOPS",  "$bGiveHalfOps $b %d" },
+    */
     { "CSMSG_SET_TOPICSNARF",    "$bTopicSnarf  $b %d" },
     { "CSMSG_SET_INVITEME",      "$bInviteMe    $b %d" },
     { "CSMSG_SET_ENFOPS",        "$bEnfOps      $b %d" },
     { "CSMSG_SET_ENFHALFOPS",    "$bEnfHalfOps  $b %d" },
+    /*
     { "CSMSG_SET_GIVE_OPS",      "$bGiveOps     $b %d" },
+    */
     { "CSMSG_SET_ENFMODES",      "$bEnfModes    $b %d" },
     { "CSMSG_SET_ENFTOPIC",      "$bEnfTopic    $b %d" },
     { "CSMSG_SET_PUBCMD",        "$bPubCmd      $b %d" },
@@ -319,10 +325,11 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_BANS_REMOVED", "Removed all channel bans from $b%s$b." },
 
 /* Channel userlist */
-    { "CSMSG_ACCESS_ALL_HEADER", "%s users from level %d to %d:" },
-    { "CSMSG_ACCESS_SEARCH_HEADER", "%s users from level %d to %d matching %s:" },
+    { "CSMSG_ACCESS_ALL_HEADER", "$b%s Users From Level %s To %s$b" },
+    { "CSMSG_ACCESS_SEARCH_HEADER", "$b%s Users From Level %s To %s Matching %s$b" },
     { "CSMSG_INVALID_ACCESS", "$b%s$b is an invalid access level." },
-    { "CSMSG_CHANGED_ACCESS", "%s now has access $b%d$b in %s." },
+    { "CSMSG_CHANGED_ACCESS", "%s now has access $b%s$b (%u) in %s." },
+    { "CSMSG_BANS_HEADER", "$bBans in %s$b" },
 
 /* Channel note list */
     { "CSMSG_NOTELIST_HEADER", "Notes for $b%s$b:" },
@@ -356,9 +363,9 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_SQUAT_ACCESS", "$b%s$b does not have access to any channels." },
     { "CSMSG_INFOLINE_LIST", "Showing all channel entries for account $b%s$b:" },
     { "CSMSG_USER_NO_ACCESS", "%s lacks access to %s." },
-    { "CSMSG_USER_HAS_ACCESS", "%s has access $b%d$b in %s." },
+    { "CSMSG_USER_HAS_ACCESS", "%s has $b%s$b access (%d) in %s." },
     { "CSMSG_HELPER_NO_ACCESS", "%s lacks access to %s but has $bsecurity override$b enabled." },
-    { "CSMSG_HELPER_HAS_ACCESS", "%s has access $b%d$b in %s and has $bsecurity override$b enabled." },
+    { "CSMSG_HELPER_HAS_ACCESS", "%s has $b%s$b access (%d) in %s and has $bsecurity override$b enabled." },
     { "CSMSG_LAZY_SMURF_TARGET", "%s is %s ($bIRCOp$b; not logged in)." },
     { "CSMSG_SMURF_TARGET", "%s is %s ($b%s$b)." },
     { "CSMSG_LAME_SMURF_TARGET", "%s is an IRC operator." },
@@ -374,7 +381,8 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_END_NAMES", "End of names in $b%s$b" },
 
 /* Channel information */
-    { "CSMSG_CHANNEL_INFO", "$b%s$b Information:" },
+    { "CSMSG_CHANNEL_INFO", "$bInformation About %s$b" },
+    { "CSMSG_BAR",  "----------------------------------------"},
     { "CSMSG_CHANNEL_TOPIC", "$bDefault Topic:       $b%s" },
     { "CSMSG_CHANNEL_MODES", "$bMode Lock:           $b%s" },
     { "CSMSG_CHANNEL_NOTE", "$b%s:%*s$b%s" },
@@ -395,13 +403,15 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_CHANNEL_SUSPENDED_7", " %s ago by %s; revoked %s ago: %s" },
     { "CSMSG_CHANNEL_REGISTERED", "$bRegistered:          $b%s ago." },
     { "CSMSG_CHANNEL_VISITED", "$bVisited:             $b%s ago." },
+    { "CSMSG_CHANNEL_END",  "---------------End of Info--------------"},
 
-    { "CSMSG_PEEK_INFO", "$b%s$b Status:" },
+    { "CSMSG_PEEK_INFO", "$bStatus of %s$b" },
     { "CSMSG_PEEK_TOPIC", "$bTopic:          $b%s" },
     { "CSMSG_PEEK_MODES", "$bModes:          $b%s" },
     { "CSMSG_PEEK_USERS", "$bTotal users:    $b%d" },
     { "CSMSG_PEEK_OPS", "$bOps:$b" },
     { "CSMSG_PEEK_NO_OPS", "$bOps:            $bNone present" },
+    { "CSMSG_PEEK_END", "-------------End of Status--------------" },
 
 /* Network information */
     { "CSMSG_NETWORK_INFO", "Network Information:" },
@@ -423,11 +433,12 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_ACTION_INVALID", "$b%s$b is not a recognized search action." },
     { "CSMSG_UNVISITED_HEADER", "Showing a maximum of %d channels unvisited for $b%s$b:" },
     { "CSMSG_UNVISITED_DATA", "%s: $b%s$b" },
-    { "CSMSG_CHANNEL_SEARCH_RESULTS", "The following channels were found:" },
+    { "CSMSG_CHANNEL_SEARCH_RESULTS", "$bChannels Found Matching Search$b" },
 
 /* Channel configuration */
     { "CSMSG_INVALID_OPTION", "$b%s$b is not a valid %s option." },
-    { "CSMSG_CHANNEL_OPTIONS", "Channel Options:" },
+    { "CSMSG_CHANNEL_OPTIONS", "$bChannel Options for %s$b" },
+    { "CSMSG_CHANNEL_OPTIONS_END", "-------------End of Options-------------" },
     { "CSMSG_GREETING_TOO_LONG", "Your greeting ($b%d$b characters) must be shorter than $b%d$b characters." },
 
 /* User settings */
@@ -447,7 +458,7 @@ static const struct message_entry msgtab[] = {
     { "CSMSG_HUGGLES_YOU", "\001ACTION huggles you\001" },
 
 /* Other things */
-    { "CSMSG_EVENT_SEARCH_RESULTS", "The following channel events were found:" },
+    { "CSMSG_EVENT_SEARCH_RESULTS", "$bChannel Events for %s$b" },
     { NULL, NULL }
 };
 
@@ -467,7 +478,7 @@ static const struct message_entry msgtab[] = {
 #define CSFUNC_ARGS            user, channel, argc, argv, cmd
 
 #define CHANSERV_FUNC(NAME) MODCMD_FUNC(NAME)
-#define CHANSERV_SYNTAX()      svccmd_send_help(user, chanserv, cmd)
+#define CHANSERV_SYNTAX()      svccmd_send_help_brief(user, chanserv, cmd)
 #define REQUIRE_PARAMS(N)      if(argc < (N)) {            \
        reply("MSG_MISSING_PARAMS", argv[0]); \
        CHANSERV_SYNTAX(); \
@@ -575,7 +586,7 @@ static const struct {
     char *title;
     unsigned short level;
     char ch;
-} accessLevels[] = {
+} accessLevels[] = { /* MUST be orderd less to most! */
     { "peon", "Peon", UL_PEON, '+' },
     { "halfop", "HalfOp", UL_HALFOP, '%' },
     { "op", "Op", UL_OP, '@' },
@@ -670,6 +681,22 @@ user_level_from_name(const char *name, unsigned short clamp_level)
     return level;
 }
 
+char *
+user_level_name_from_level(int level)
+{
+    unsigned int ii;
+    char* highest;
+
+    highest = "None";
+    if(level >= 1)
+        highest = "Peon";
+    for(ii = 0; (ii < ArrayLength(accessLevels)); ii++)
+        if(level >= accessLevels[ii].level)
+            highest = accessLevels[ii].title;
+    return(highest);
+}
+
+
 int
 parse_level_range(unsigned short *minl, unsigned short *maxl, const char *arg)
 {
@@ -1443,7 +1470,7 @@ validate_op(struct userNode *user, struct chanNode *channel, struct userNode *vi
     struct userData *cs_victim;
 
     if((!(cs_victim = GetChannelUser(cData, victim->handle_info))
-        || (cs_victim->access < cData->lvlOpts[lvlGiveOps]))
+        || (cs_victim->access < UL_OP /* cData->lvlOpts[lvlGiveOps]*/))
        && !check_user_level(channel, user, lvlEnfOps, 0, 0))
     {
        send_message(user, chanserv, "CSMSG_OPBY_LOCKED");
@@ -1460,7 +1487,7 @@ validate_halfop(struct userNode *user, struct chanNode *channel, struct userNode
     struct userData *cs_victim;
 
     if((!(cs_victim = GetChannelUser(cData, victim->handle_info))
-        || (cs_victim->access < cData->lvlOpts[lvlGiveHalfOps]))
+        || (cs_victim->access < UL_HALFOP /* cData->lvlOpts[lvlGiveHalfOps] */))
        && !check_user_level(channel, user, lvlEnfHalfOps, 0, 0))
     {
         send_message(user, chanserv, "CSMSG_HOPBY_LOCKED");
@@ -1600,6 +1627,7 @@ static CHANSERV_FUNC(cmd_noregister)
         dict_iterator_t it;
 
         reply("CSMSG_DNR_SEARCH_RESULTS");
+        reply("CSMSG_BAR");
         matches = 0;
         for(it = dict_first(handle_dnrs); it; it = iter_next(it))
         {
@@ -1658,6 +1686,7 @@ static CHANSERV_FUNC(cmd_noregister)
     }
 
     reply("CSMSG_DNR_SEARCH_RESULTS");
+    reply("CSMSG_BAR");
     if(*target == '*')
         matches = chanserv_show_dnrs(user, cmd, NULL, target + 1);
     else
@@ -1742,7 +1771,13 @@ static CHANSERV_FUNC(cmd_register)
     }
     else
     {
-        if((argc < 2) || !IsChannelName(argv[1]))
+        if(argc < 2)
+        {
+          reply("MSG_MISSING_PARAMS", cmd->name);
+          svccmd_send_help_brief(user, chanserv, cmd);
+          return 0;
+        }
+        if(!IsChannelName(argv[1]))
         {
             reply("MSG_NOT_CHANNEL_NAME");
             return 0;
@@ -2273,13 +2308,13 @@ static CHANSERV_FUNC(cmd_adduser)
 
     if((actee = GetTrueChannelAccess(channel->channel_info, handle)))
     {
-       reply("CSMSG_USER_EXISTS", handle->handle, channel->name, actee->access);
+       reply("CSMSG_USER_EXISTS", handle->handle, channel->name, user_level_name_from_level(actee->access));
        return 0;
     }
 
     actee = add_channel_user(channel->channel_info, handle, access, 0, NULL);
     scan_user_presence(actee, NULL);
-    reply("CSMSG_ADDED_USER", handle->handle, channel->name, access);
+    reply("CSMSG_ADDED_USER", handle->handle, channel->name, user_level_name_from_level(access), access);
     return 1;
 }
 
@@ -2331,7 +2366,7 @@ static CHANSERV_FUNC(cmd_clvl)
     }
 
     victim->access = new_access;
-    reply("CSMSG_CHANGED_ACCESS", handle->handle, new_access, channel->name);
+    reply("CSMSG_CHANGED_ACCESS", handle->handle, user_level_name_from_level(new_access), new_access, channel->name);
     return 1;
 }
 
@@ -2366,7 +2401,7 @@ static CHANSERV_FUNC(cmd_deluser)
         }
        if(access != victim->access)
        {
-           reply("CSMSG_INCORRECT_ACCESS", handle->handle, victim->access, argv[1]);
+           reply("CSMSG_INCORRECT_ACCESS", handle->handle, user_level_name_from_level(victim->access), argv[1]);
            return 0;
        }
     }
@@ -2591,17 +2626,17 @@ static CHANSERV_FUNC(cmd_up)
             reply("CSMSG_GODMODE_UP", argv[0]);
         return 0;
     }
-    else if(uData->access >= channel->channel_info->lvlOpts[lvlGiveOps])
+    else if(uData->access >= UL_OP /*channel->channel_info->lvlOpts[lvlGiveOps]*/)
     {
         change.args[0].mode = MODE_CHANOP;
         errmsg = "CSMSG_ALREADY_OPPED";
     }
-    else if(uData->access >= channel->channel_info->lvlOpts[lvlGiveHalfOps])
+    else if(uData->access >= UL_HALFOP /*channel->channel_info->lvlOpts[lvlGiveHalfOps]*/)
     {
         change.args[0].mode = MODE_HALFOP;
         errmsg = "CSMSG_ALREADY_HALFOPPED";
     }
-    else if(uData->access >= channel->channel_info->lvlOpts[lvlGiveVoice])
+    else if(uData->access >= UL_PEON /* channel->channel_info->lvlOpts[lvlGiveVoice]*/)
     {
         change.args[0].mode = MODE_VOICE;
         errmsg = "CSMSG_ALREADY_VOICED";
@@ -3163,9 +3198,9 @@ unban_user(struct userNode *user, struct chanNode *channel, unsigned int argc, c
         {
             unsigned int ii;
 
+            modcmd_chanmode_announce(change);
             for(ii = 0; ii < change->argc; ++ii)
                 free((char*)change->args[ii].u.hostmask);
-            modcmd_chanmode_announce(change);
             mod_chanmode_free(change);
             acted = 1;
         }
@@ -3313,11 +3348,11 @@ static CHANSERV_FUNC(cmd_myaccess)
             string_buffer_append(&sbuf, 's');
         if(IsUserAutoOp(uData))
         {
-            if(uData->access >= cData->lvlOpts[lvlGiveOps])
+            if(uData->access >= UL_OP /*cData->lvlOpts[lvlGiveOps]*/)
                 string_buffer_append(&sbuf, 'o');
-            else if(uData->access >= cData->lvlOpts[lvlGiveHalfOps])
+            else if(uData->access >= UL_HALFOP /*cData->lvlOpts[lvlGiveHalfOps]*/)
                 string_buffer_append(&sbuf, 'h');
-            else if(uData->access >= cData->lvlOpts[lvlGiveVoice])
+            else if(uData->access >= UL_PEON /*cData->lvlOpts[lvlGiveVoice]*/)
                 string_buffer_append(&sbuf, 'v');
         }
         if(IsUserAutoInvite(uData) && (uData->access >= cData->lvlOpts[lvlInviteMe]))
@@ -3430,7 +3465,7 @@ static CHANSERV_FUNC(cmd_access)
         && ((target_handle->opserv_level >= chanserv_conf.nodelete_level) || !IsProtected(channel->channel_info));
     if((uData = GetTrueChannelAccess(channel->channel_info, target_handle)))
     {
-        reply((helping ? "CSMSG_HELPER_HAS_ACCESS" : "CSMSG_USER_HAS_ACCESS"), prefix, uData->access, channel->name);
+        reply((helping ? "CSMSG_HELPER_HAS_ACCESS" : "CSMSG_USER_HAS_ACCESS"), prefix, user_level_name_from_level(uData->access), uData->access, channel->name);
         /* To prevent possible information leaks, only show infolines
          * if the requestor is in the channel or it's their own
          * handle. */
@@ -3455,6 +3490,7 @@ static CHANSERV_FUNC(cmd_access)
     return 1;
 }
 
+/* This is never used... */
 static void
 zoot_list(struct listData *list)
 {
@@ -3466,9 +3502,9 @@ zoot_list(struct listData *list)
     if(list->table.length == 1)
     {
         if(list->search)
-            send_message(list->user, list->bot, "CSMSG_ACCESS_SEARCH_HEADER", list->channel->name, list->lowest, list->highest, list->search);
+            send_message(list->user, list->bot, "CSMSG_ACCESS_SEARCH_HEADER", list->channel->name, user_level_name_from_level(list->lowest), user_level_name_from_level(list->highest), list->search);
         else
-            send_message(list->user, list->bot, "CSMSG_ACCESS_ALL_HEADER", list->channel->name, list->lowest, list->highest);
+            send_message(list->user, list->bot, "CSMSG_ACCESS_ALL_HEADER", list->channel->name, user_level_name_from_level(list->lowest), user_level_name_from_level(list->highest));
         msg = user_find_message(list->user, "MSG_NONE");
         send_message_type(4, list->user, list->bot, "  %s", msg);
     }
@@ -3489,9 +3525,9 @@ zoot_list(struct listData *list)
         if((curr == list->table.length) || (list->users[curr-1]->access < lowest))
         {
             if(list->search)
-                send_message(list->user, list->bot, "CSMSG_ACCESS_SEARCH_HEADER", list->channel->name, lowest, highest, list->search);
+                send_message(list->user, list->bot, "CSMSG_ACCESS_SEARCH_HEADER", list->channel->name, user_level_name_from_level(lowest), user_level_name_from_level(highest), list->search);
             else
-                send_message(list->user, list->bot, "CSMSG_ACCESS_ALL_HEADER", list->channel->name, lowest, highest);
+                send_message(list->user, list->bot, "CSMSG_ACCESS_ALL_HEADER", list->channel->name, user_level_name_from_level(lowest), user_level_name_from_level(highest));
             temp = list->table.contents[--start];
             list->table.contents[start] = list->table.contents[0];
             tmp_table.contents = list->table.contents + start;
@@ -3510,9 +3546,9 @@ def_list(struct listData *list)
 {
     const char *msg;
     if(list->search)
-        send_message(list->user, list->bot, "CSMSG_ACCESS_SEARCH_HEADER", list->channel->name, list->lowest, list->highest, list->search);
+        send_message(list->user, list->bot, "CSMSG_ACCESS_SEARCH_HEADER", list->channel->name, user_level_name_from_level(list->lowest), user_level_name_from_level(list->highest), list->search);
     else
-        send_message(list->user, list->bot, "CSMSG_ACCESS_ALL_HEADER", list->channel->name, list->lowest, list->highest);
+        send_message(list->user, list->bot, "CSMSG_ACCESS_ALL_HEADER", list->channel->name, user_level_name_from_level(list->lowest), user_level_name_from_level(list->highest));
     table_send(list->bot, list->user->nick, 0, NULL, list->table);
     if(list->table.length == 1)
     {
@@ -3550,8 +3586,10 @@ cmd_list_users(struct userNode *user, struct chanNode *channel, unsigned int arg
     lData.highest = highest;
     lData.search = (argc > 1) ? argv[1] : NULL;
     send_list = def_list;
+    /* What does the following line do exactly?? */
     (void)zoot_list; /* since it doesn't show user levels */
 
+    /* this does nothing!! -rubin
     if(user->handle_info)
     {
        switch(user->handle_info->userlist_style)
@@ -3560,6 +3598,7 @@ cmd_list_users(struct userNode *user, struct chanNode *channel, unsigned int arg
         case HI_STYLE_ZOOT: send_list = def_list; break;
        }
     }
+    */
 
     lData.users = alloca(channel->channel_info->userCount * sizeof(struct userData *));
     matches = 0;
@@ -3574,15 +3613,16 @@ cmd_list_users(struct userNode *user, struct chanNode *channel, unsigned int arg
     qsort(lData.users, matches, sizeof(lData.users[0]), userData_access_comp);
 
     lData.table.length = matches+1;
-    lData.table.width = 4;
+    lData.table.width = 5;
     lData.table.flags = TABLE_NO_FREE;
     lData.table.contents = malloc(lData.table.length*sizeof(*lData.table.contents));
     ary = malloc(lData.table.width*sizeof(**lData.table.contents));
     lData.table.contents[0] = ary;
     ary[0] = "Access";
-    ary[1] = "Account";
-    ary[2] = "Last Seen";
-    ary[3] = "Status";
+    ary[1] = "Level";
+    ary[2] = "Account";
+    ary[3] = "Last Seen";
+    ary[4] = "Status";
     for(matches = 1; matches < lData.table.length; ++matches)
     {
         struct userData *uData = lData.users[matches-1];
@@ -3590,26 +3630,30 @@ cmd_list_users(struct userNode *user, struct chanNode *channel, unsigned int arg
 
         ary = malloc(lData.table.width*sizeof(**lData.table.contents));
         lData.table.contents[matches] = ary;
-        ary[0] = strtab(uData->access);
-        ary[1] = uData->handle->handle;
+        /* ary[0] = strtab(uData->access);*/
+        ary[0] = user_level_name_from_level(uData->access);
+        /* TODO: replace above with func that returns static string
+         * of userlevel for that level. eg OP/MANAGER etc. -rubin */
+        ary[1] = strtab(uData->access);
+        ary[2] = uData->handle->handle;
         if(uData->present)
-            ary[2] = "Here";
+            ary[3] = "Here";
         else if(!uData->seen)
-            ary[2] = "Never";
+            ary[3] = "Never";
         else
-            ary[2] = intervalString(seen, now - uData->seen, user->handle_info);
-        ary[2] = strdup(ary[2]);
+            ary[3] = intervalString(seen, now - uData->seen, user->handle_info);
+        ary[3] = strdup(ary[3]);
         if(IsUserSuspended(uData))
-            ary[3] = "Suspended";
+            ary[4] = "Suspended";
         else if(HANDLE_FLAGGED(uData->handle, FROZEN))
-            ary[3] = "Vacation";
+            ary[4] = "Vacation";
         else
-            ary[3] = "Normal";
+            ary[4] = "Normal";
     }
     send_list(&lData);
     for(matches = 1; matches < lData.table.length; ++matches)
     {
-        free((char*)lData.table.contents[matches][2]);
+        free((char*)lData.table.contents[matches][3]);
         free(lData.table.contents[matches]);
     }
     free(lData.table.contents[0]);
@@ -3665,6 +3709,7 @@ static CHANSERV_FUNC(cmd_bans)
     else
         search = NULL;
 
+    reply("CSMSG_BANS_HEADER", channel->name);
     bans = alloca(channel->channel_info->banCount * sizeof(struct banData *));
 
     for(ban = channel->channel_info->bans; ban; ban = ban->next)
@@ -3731,7 +3776,7 @@ static CHANSERV_FUNC(cmd_bans)
             tbl.contents[ii][3] = ban->reason;
     }
     table_send(cmd->parent->bot, user->nick, 0, NULL, tbl);
-    reply("MSG_MATCH_COUNT", matches);
+    /* reply("MSG_MATCH_COUNT", matches); */
     for(ii = 1; ii < tbl.length; ++ii)
     {
         free((char*)tbl.contents[ii][2]);
@@ -3744,20 +3789,71 @@ static CHANSERV_FUNC(cmd_bans)
     return 1;
 }
 
+/* bad_topic
+ *
+ * return + if the user does NOT have the right to set the topic, and
+ * the topic is changed.
+ */
 static int
 bad_topic(struct chanNode *channel, struct userNode *user, const char *new_topic)
 {
     struct chanData *cData = channel->channel_info;
     if(check_user_level(channel, user, lvlEnfTopic, 1, 0))
         return 0;
-    if(cData->topic_mask)
-        return !match_ircglob(new_topic, cData->topic_mask);
     else if(cData->topic)
         return irccasecmp(new_topic, cData->topic);
     else
         return 0;
 }
 
+/* conform_topic
+ *
+ * Makes a givin topic fit into a givin topic mask and returns
+ * the results.
+ *
+ * topic_mask - the mask to conform to
+ * topic - the topic to make conform
+ * new_topic - the pre-allocated char* to put the new topic into
+ *
+ * modifies: new_topic
+ */
+void
+conform_topic(char* topic_mask, char* topic, char *new_topic)
+{
+    //char *topic_mask = cData->topic_mask;
+    char tchar;
+    int pos=0, starpos=-1, dpos=0, len;
+
+    while((tchar = topic_mask[pos++]) && (dpos <= TOPICLEN))
+    {
+        switch(tchar)
+        {
+        case '*':
+            if(starpos != -1)
+            {
+                strcpy(new_topic, "");
+                return;
+            }
+            len = strlen(topic);
+            if((dpos + len) > TOPICLEN)
+                len = TOPICLEN + 1 - dpos;
+            memcpy(new_topic+dpos, topic, len);
+            dpos += len;
+            starpos = pos;
+            break;
+        case '\\': tchar = topic_mask[pos++]; /* and fall through */
+        default: new_topic[dpos++] = tchar; break;
+        }
+    }
+    if((dpos > TOPICLEN) || tchar)
+    {
+        strcpy(new_topic, "");
+        return;
+    }
+    new_topic[dpos] = 0;
+    return;
+}
+
 static CHANSERV_FUNC(cmd_topic)
 {
     struct chanData *cData;
@@ -3766,12 +3862,12 @@ static CHANSERV_FUNC(cmd_topic)
     cData = channel->channel_info;
     if(argc < 2)
     {
-       if(cData->topic)
-       {
-           SetChannelTopic(channel, chanserv, cData->topic, 1);
-           reply("CSMSG_TOPIC_SET", cData->topic);
+        if(cData->topic)
+        {
+            SetChannelTopic(channel, chanserv, cData->topic, 1);
+            reply("CSMSG_TOPIC_SET", cData->topic);
             return 1;
-       }
+        }
 
         reply("CSMSG_NO_TOPIC", channel->name);
         return 0;
@@ -3781,48 +3877,34 @@ static CHANSERV_FUNC(cmd_topic)
     /* If they say "!topic *", use an empty topic. */
     if((topic[0] == '*') && (topic[1] == 0))
         topic[0] = 0;
+
     if(bad_topic(channel, user, topic))
     {
-        char *topic_mask = cData->topic_mask;
-        if(topic_mask)
+        reply("CSMSG_TOPIC_LOCKED", channel->name);
+        return 0;
+    }
+    else
+    {
+        /* If there is a topicmask set, and the new topic doesnt match, make it */
+        if(cData->topic_mask && !match_ircglob(topic, cData->topic_mask))
         {
-            char new_topic[TOPICLEN+1], tchar;
-            int pos=0, starpos=-1, dpos=0, len;
+            char *topic_mask = cData->topic_mask;
+            char new_topic[TOPICLEN+1];
 
-            while((tchar = topic_mask[pos++]) && (dpos <= TOPICLEN))
+            /* make a new topic fitting mask */
+            conform_topic(topic_mask, topic, new_topic);
+            if(!*new_topic)
             {
-                switch(tchar)
-                {
-                case '*':
-                    if(starpos != -1)
-                        goto bad_mask;
-                    len = strlen(topic);
-                    if((dpos + len) > TOPICLEN)
-                        len = TOPICLEN + 1 - dpos;
-                    memcpy(new_topic+dpos, topic, len);
-                    dpos += len;
-                    starpos = pos;
-                    break;
-                case '\\': tchar = topic_mask[pos++]; /* and fall through */
-                default: new_topic[dpos++] = tchar; break;
-                }
-            }
-            if((dpos > TOPICLEN) || tchar)
-            {
-            bad_mask:
+                /* Topic couldnt fit into mask, was too long */
                 reply("CSMSG_TOPICMASK_CONFLICT1", channel->name, topic_mask);
                 reply("CSMSG_TOPICMASK_CONFLICT2", TOPICLEN);
                 return 0;
             }
-            new_topic[dpos] = 0;
             SetChannelTopic(channel, chanserv, new_topic, 1);
-        } else {
-            reply("CSMSG_TOPIC_LOCKED", channel->name);
-            return 0;
         }
+        else /* No mask set, just set the topic */
+            SetChannelTopic(channel, chanserv, topic, 1);
     }
-    else
-        SetChannelTopic(channel, chanserv, topic, 1);
 
     if(check_user_level(channel, user, lvlTopicSnarf, 1, 0))
     {
@@ -3996,9 +4078,10 @@ static CHANSERV_FUNC(cmd_info)
 
     cData = channel->channel_info;
     reply("CSMSG_CHANNEL_INFO", channel->name);
+    reply("CSMSG_BAR");
 
     uData = GetChannelUser(cData, user->handle_info);
-    if(uData && (uData->access >= cData->lvlOpts[lvlGiveOps]))
+    if(uData && (uData->access >= UL_OP /*cData->lvlOpts[lvlGiveOps]*/))
     {
         mod_chanmode_format(&cData->modes, modes);
        reply("CSMSG_CHANNEL_TOPIC", cData->topic);
@@ -4045,6 +4128,7 @@ static CHANSERV_FUNC(cmd_info)
         reply("CSMSG_CHANNEL_SUSPENDED", channel->name);
         show_suspension_info(cmd, user, cData->suspended);
     }
+    reply("CSMSG_CHANNEL_END");
     return 1;
 }
 
@@ -4131,6 +4215,7 @@ static CHANSERV_FUNC(cmd_peek)
     irc_make_chanmode(channel, modes);
 
     reply("CSMSG_PEEK_INFO", channel->name);
+    reply("CSMSG_BAR");
     reply("CSMSG_PEEK_TOPIC", channel->topic);
     reply("CSMSG_PEEK_MODES", modes);
     reply("CSMSG_PEEK_USERS", channel->members.used);
@@ -4155,6 +4240,7 @@ static CHANSERV_FUNC(cmd_peek)
     }
     else
         reply("CSMSG_PEEK_NO_OPS");
+    reply("CSMSG_PEEK_END");
     return 1;
 }
 
@@ -4200,8 +4286,7 @@ static CHANSERV_FUNC(cmd_resync)
             continue;
 
         uData = GetChannelAccess(cData, mn->user->handle_info);
-        if(!cData->lvlOpts[lvlGiveOps]
-           || (uData && uData->access >= cData->lvlOpts[lvlGiveOps]))
+        if(uData && uData->access >= UL_OP /* cData->lvlOpts[lvlGiveOps]*/)
         {
             if(!(mn->modes & MODE_CHANOP))
             {
@@ -4209,8 +4294,7 @@ static CHANSERV_FUNC(cmd_resync)
                 changes->args[used++].u.member = mn;
             }
         }
-        else if(!cData->lvlOpts[lvlGiveHalfOps]
-                || (uData && uData->access >= cData->lvlOpts[lvlGiveHalfOps]))
+        else if(uData && uData->access >= UL_HALFOP /*cData->lvlOpts[lvlGiveHalfOps]*/)
         {
             if(!(mn->modes & MODE_HALFOP))
             {
@@ -4228,8 +4312,7 @@ static CHANSERV_FUNC(cmd_resync)
                 changes->args[used++].u.member = mn;
             }
         }
-        else if(!cData->lvlOpts[lvlGiveVoice]
-                || (uData && uData->access >= cData->lvlOpts[lvlGiveVoice]))
+        else if(uData && uData->access >= UL_PEON /* cData->lvlOpts[lvlGiveVoice]*/)
         {
             if(mn->modes & MODE_CHANOP)
             {
@@ -4487,7 +4570,8 @@ static CHANSERV_FUNC(cmd_events)
     discrim.severities = 1 << LOG_COMMAND;
     report.reporter = chanserv;
     report.user = user;
-    reply("CSMSG_EVENT_SEARCH_RESULTS");
+    reply("CSMSG_EVENT_SEARCH_RESULTS", channel->name);
+    reply("CSMSG_BAR");
     matches = log_entry_search(&discrim, log_report_entry, &report);
     if(matches)
        reply("MSG_MATCH_COUNT", matches);
@@ -4822,7 +4906,10 @@ static CHANSERV_FUNC(cmd_search)
        search->limit = INT_MAX;
 
     if(action == search_print)
+    {
        reply("CSMSG_CHANNEL_SEARCH_RESULTS");
+        reply("CSMSG_BAR");
+    }
 
     matches = chanserv_channel_search(search, action, user);
 
@@ -5185,6 +5272,7 @@ channel_level_option(enum levelOption option, struct userNode *user, struct chan
         }
         switch(option)
         {
+            /* removing these level sets..
         case lvlGiveVoice:
             if(value > cData->lvlOpts[lvlGiveOps])
             {
@@ -5206,6 +5294,7 @@ channel_level_option(enum levelOption option, struct userNode *user, struct chan
                 return 0;
             }
             break;
+            */
         case lvlSetters:
             /* This test only applies to owners, since non-owners
              * trying to set an option to above their level get caught
@@ -5235,7 +5324,7 @@ static MODCMD_FUNC(chan_opt_enfhalfops)
 {
     return channel_level_option(lvlEnfHalfOps, CSFUNC_ARGS);
 }
-
+/*
 static MODCMD_FUNC(chan_opt_giveops)
 {
     return channel_level_option(lvlGiveOps, CSFUNC_ARGS);
@@ -5245,7 +5334,7 @@ static MODCMD_FUNC(chan_opt_givehalfops)
 {
     return channel_level_option(lvlGiveHalfOps, CSFUNC_ARGS);
 }
-
+*/
 static MODCMD_FUNC(chan_opt_enfmodes)
 {
     return channel_level_option(lvlEnfModes, CSFUNC_ARGS);
@@ -5276,10 +5365,12 @@ static MODCMD_FUNC(chan_opt_userinfo)
     return channel_level_option(lvlUserInfo, CSFUNC_ARGS);
 }
 
+/*
 static MODCMD_FUNC(chan_opt_givevoice)
 {
     return channel_level_option(lvlGiveVoice, CSFUNC_ARGS);
 }
+*/
 
 static MODCMD_FUNC(chan_opt_topicsnarf)
 {
@@ -5391,12 +5482,14 @@ static CHANSERV_FUNC(cmd_set)
 
     if(argc < 2)
     {
-       reply("CSMSG_CHANNEL_OPTIONS");
+       reply("CSMSG_CHANNEL_OPTIONS", channel->name);
+        reply("CSMSG_BAR");
         for(ii = 0; ii < set_shows_list.used; ii++)
         {
             subcmd = set_shows_list.list[ii];
             subcmd->command->func(user, channel, 1, argv+1, subcmd);
         }
+        reply("CSMSG_CHANNEL_OPTIONS_END");
        return 1;
     }
 
@@ -5460,10 +5553,11 @@ static MODCMD_FUNC(user_opt_noautoop)
         reply("CSMSG_NOT_USER", channel->name);
         return 0;
     }
-    if(uData->access < channel->channel_info->lvlOpts[lvlGiveOps])
+    if(uData->access < UL_OP /*channel->channel_info->lvlOpts[lvlGiveOps]*/)
         return user_binary_option("CSMSG_USET_NOAUTOVOICE", USER_AUTO_OP, CSFUNC_ARGS);
     else
         return user_binary_option("CSMSG_USET_NOAUTOOP", USER_AUTO_OP, CSFUNC_ARGS);
+    /* TODO: add halfops error message? or is the op one generic enough? */
 }
 
 static MODCMD_FUNC(user_opt_autoinvite)
@@ -6076,13 +6170,14 @@ handle_join(struct modeNode *mNode)
     {
         /* don't automatically give ops or voice during a join flood */
     }
+    /* I don't understand why we do this, so im removing it -rubin *
     else if(cData->lvlOpts[lvlGiveOps] == 0)
         modes |= MODE_CHANOP;
     else if(cData->lvlOpts[lvlGiveHalfOps] == 0)
         modes |= MODE_HALFOP;
     else if(cData->lvlOpts[lvlGiveVoice] == 0)
         modes |= MODE_VOICE;
-
+    */
     greeting = cData->greeting;
     if(user->handle_info)
     {
@@ -6107,11 +6202,11 @@ handle_join(struct modeNode *mNode)
             /* Ops and above were handled by the above case. */
             if(IsUserAutoOp(uData))
             {
-                if(uData->access >= cData->lvlOpts[lvlGiveOps])
+                if(uData->access >= UL_OP /*cData->lvlOpts[lvlGiveOps]*/)
                     modes |= MODE_CHANOP;
-                if(uData->access >= cData->lvlOpts[lvlGiveHalfOps])
+                if(uData->access >= UL_HALFOP /*cData->lvlOpts[lvlGiveHalfOps]*/)
                     modes |= MODE_HALFOP;
-                else if(uData->access >= cData->lvlOpts[lvlGiveVoice])
+                else if(uData->access >= UL_PEON /* cData->lvlOpts[lvlGiveVoice] */)
                     modes |= MODE_VOICE;
             }
             if(uData->access >= UL_PRESENT)
@@ -6185,11 +6280,11 @@ handle_auth(struct userNode *user, UNUSED_ARG(struct handle_info *old_handle))
 
         if(IsUserAutoOp(channel))
         {
-            if(channel->access >= cn->channel_info->lvlOpts[lvlGiveOps])
+            if(channel->access >= UL_OP /* cn->channel_info->lvlOpts[lvlGiveOps] */)
                 change.args[0].mode = MODE_CHANOP;
-            else if(channel->access >= cn->channel_info->lvlOpts[lvlGiveHalfOps])
+            else if(channel->access >= UL_HALFOP /* cn->channel_info->lvlOpts[lvlGiveHalfOps]*/)
                 change.args[0].mode = MODE_HALFOP;
-            else if(channel->access >= cn->channel_info->lvlOpts[lvlGiveVoice])
+            else if(channel->access >= UL_PEON /* cn->channel_info->lvlOpts[lvlGiveVoice]*/)
                 change.args[0].mode = MODE_VOICE;
             else
                 change.args[0].mode = 0;
@@ -6317,14 +6412,30 @@ handle_topic(struct userNode *user, struct chanNode *channel, const char *old_to
 
     cData = channel->channel_info;
     if(bad_topic(channel, user, channel->topic))
-    {
+    {   /* User doesnt have privs to set topics. Undo it */
         send_message(user, chanserv, "CSMSG_TOPIC_LOCKED", channel->name);
-        if(cData->topic_mask && match_ircglob(old_topic, cData->topic_mask))
-            SetChannelTopic(channel, chanserv, old_topic, 1);
-        else if(cData->topic)
-            SetChannelTopic(channel, chanserv, cData->topic, 1);
+        SetChannelTopic(channel, chanserv, old_topic, 1);
         return 1;
     }
+    /* If there is a topic mask set, and the new topic doesnt match,
+     * set the topic to mask + new_topic */
+    if(cData->topic_mask && !match_ircglob(channel->topic, cData->topic_mask))
+    {
+        char new_topic[TOPICLEN+1];
+        conform_topic(cData->topic_mask, channel->topic, new_topic);
+        if(*new_topic)
+        {
+           SetChannelTopic(channel, chanserv, new_topic, 1);
+           /* and fall through to topicsnarf code below.. */
+        }
+        else /* Topic couldnt fit into mask, was too long */
+        {
+            SetChannelTopic(channel, chanserv, old_topic, 1);
+            send_message(user, chanserv, "CSMSG_TOPICMASK_CONFLICT1", channel->name, cData->topic_mask);
+            send_message(user, chanserv, "CSMSG_TOPICMASK_CONFLICT2", TOPICLEN);
+            return 1;
+        }
+    }
     /* With topicsnarf, grab the topic and save it as the default topic. */
     if(check_user_level(channel, user, lvlTopicSnarf, 0, 0))
     {
@@ -6601,7 +6712,7 @@ chanserv_conf_read(void)
             /* free form text */
             "DefaultTopic", "TopicMask", "Greeting", "UserGreeting", "Modes",
             /* options based on user level */
-            "PubCmd", "InviteMe", "UserInfo", "GiveVoice", "GiveHalfOps", "GiveOps", "EnfOps",
+            "PubCmd", "InviteMe", "UserInfo",/* "GiveVoice", "GiveHalfOps", "GiveOps", */ "EnfOps",
             "EnfHalfOps", "EnfModes", "EnfTopic", "TopicSnarf", "Setters", "CtcpUsers",
             /* multiple choice options */
             "CtcpReaction", "Protect", "Toys", "TopicRefresh",
@@ -7430,13 +7541,15 @@ init_chanserv(const char *nick)
     DEFINE_CHANNEL_OPTION(modes);
     DEFINE_CHANNEL_OPTION(enfops);
     DEFINE_CHANNEL_OPTION(enfhalfops);
-    DEFINE_CHANNEL_OPTION(giveops);
+    /*DEFINE_CHANNEL_OPTION(giveops);
     DEFINE_CHANNEL_OPTION(givehalfops);
+    */
     DEFINE_CHANNEL_OPTION(protect);
     DEFINE_CHANNEL_OPTION(enfmodes);
     DEFINE_CHANNEL_OPTION(enftopic);
     DEFINE_CHANNEL_OPTION(pubcmd);
-    DEFINE_CHANNEL_OPTION(givevoice);
+    /*DEFINE_CHANNEL_OPTION(givevoice);
+     */
     DEFINE_CHANNEL_OPTION(userinfo);
     DEFINE_CHANNEL_OPTION(dynlimit);
     DEFINE_CHANNEL_OPTION(topicsnarf);