]>
jfr.im git - irc/charybdis-ircd/charybdis.git/log
Simon Arlott [Thu, 18 Jan 2018 21:38:16 +0000 (21:38 +0000)]
charybdis 4.0.1
Simon Arlott [Thu, 18 Jan 2018 21:33:26 +0000 (21:33 +0000)]
ircd: use correct buffer sizes
This fixes an issue with truncated SJOINs.
Aaron Jones [Sat, 6 Jan 2018 16:18:44 +0000 (16:18 +0000)]
.travis.yml: don't use specific clang version
Aaron Jones [Sat, 6 Jan 2018 15:59:04 +0000 (15:59 +0000)]
libratbox/src/mbedtls.c: check public/private keys match
Aaron Jones [Thu, 23 Nov 2017 18:09:48 +0000 (18:09 +0000)]
modules/cap_server_time.c: fix logic error
cap_server_time.c:60:76: warning: comparison of unsigned expression < 0
is always false
[-Wtautological-unsigned-zero-compare]
if (strftime(buf, sizeof(buf), "%Y-%m-%dT%H:%M:%S.", gmtime(&tv.tv_sec)) < 0)
Aaron Jones [Thu, 23 Nov 2017 17:53:05 +0000 (17:53 +0000)]
.gitignore: don't include shtool and install-sh anymore
Subsequent to commit
b5e8833c78f50028 these files are automatically
generated now.
Aaron Jones [Thu, 23 Nov 2017 17:51:21 +0000 (17:51 +0000)]
autogen.sh: report correct exit status from failed commands
test(1) may overwrite the $? special variable, so cache its value
first.
jackal [Mon, 20 Nov 2017 19:25:17 +0000 (21:25 +0200)]
Rename extensions/README to index.txt
jackal [Mon, 20 Nov 2017 19:22:27 +0000 (21:22 +0200)]
Update license to more recent GPLv2
jackal [Mon, 20 Nov 2017 19:13:22 +0000 (21:13 +0200)]
Remove appveyor and have osx install shtool before build
jackal [Mon, 20 Nov 2017 18:57:17 +0000 (20:57 +0200)]
Trim autogen.sh a bit and add shtool to it
Aaron Jones [Wed, 15 Nov 2017 21:16:10 +0000 (21:16 +0000)]
Fix regression introduced in previous commit
jackal [Wed, 15 Nov 2017 21:02:37 +0000 (23:02 +0200)]
update export-syms.txt
jackal [Wed, 15 Nov 2017 17:25:49 +0000 (19:25 +0200)]
Various Makefile improvements
Aaron Jones [Sat, 4 Nov 2017 07:40:44 +0000 (07:40 +0000)]
doc/reference.conf: clarify that server link fingerprints aren't optional
[ci skip]
Aaron Jones [Mon, 30 Oct 2017 15:45:23 +0000 (15:45 +0000)]
help/Makefile.am: silence construction of indexes, make build depend on index
Aaron Jones [Sat, 28 Oct 2017 17:10:47 +0000 (17:10 +0000)]
Merge pull request #253 from Mkaysi/sno_whois
extensions/sno_whois.c: fix comment
Aaron Jones [Sat, 28 Oct 2017 17:08:18 +0000 (17:08 +0000)]
Merge pull request #252 from Mkaysi/doc-snomask
help/opers/snomask: add extension snomasks
Mikaela Suomalainen [Sat, 28 Oct 2017 17:07:56 +0000 (20:07 +0300)]
extensions/sno_whois.c: fix comment
When discussing #252 it was noticed that the comment is wrong.
Mikaela Suomalainen [Sat, 28 Oct 2017 15:57:02 +0000 (18:57 +0300)]
help/opers/snomask: add extension snomasks
Simon Arlott [Fri, 20 Oct 2017 22:29:47 +0000 (23:29 +0100)]
charybdis 4.0
Simon Arlott [Thu, 24 Aug 2017 19:12:17 +0000 (20:12 +0100)]
charybdis 4-rc7
Simon Arlott [Thu, 24 Aug 2017 19:07:31 +0000 (20:07 +0100)]
exit_unknown_client: don't delete servers from the client hash
Outgoing servers are not added to the client hash until they reach
IsServer() status, so if they're unknown when they exit then don't
attempt to delete them.
Simon Arlott [Thu, 24 Aug 2017 19:03:51 +0000 (20:03 +0100)]
tests: add serv_connect1 (exit_unknown_client)
Test serv_connect followed by exit_unknown_client.
An outgoing connection should not delete an incoming connection that
occurs during the connection attempt.
Simon Arlott [Tue, 22 Aug 2017 20:55:03 +0000 (21:55 +0100)]
s_serv: connect using both IPv4 and IPv6 if unspecified
Simon Arlott [Sun, 20 Aug 2017 11:53:44 +0000 (12:53 +0100)]
authd: assume all providers are running
Otherwise ident returns without setting itself running causing problems.
Move opm/blacklist before ident/rdns so that they can receive completion
notifications.
Simon Arlott [Wed, 9 Aug 2017 21:04:11 +0000 (22:04 +0100)]
m_sasl: indicate client connection type for SASL
Simon Arlott [Sun, 6 Aug 2017 17:40:24 +0000 (18:40 +0100)]
librb: remove zstring
rb_zstring_serialized leaks memory while doing nothing with its
arguments... nothing is using zstring so remove it
Simon Arlott [Sun, 6 Aug 2017 17:38:25 +0000 (18:38 +0100)]
tests: add rb_dictionary1
This doesn't do much because replacing existing elements isn't allowed.
Simon Arlott [Sun, 6 Aug 2017 17:37:20 +0000 (18:37 +0100)]
librb: dictionary_add mishandles replacing elements
This can only happen with soft asserts otherwise it will crash instead.
Nothing currently uses the return value of rb_dictionary_add.
Simon Arlott [Sun, 6 Aug 2017 15:43:49 +0000 (16:43 +0100)]
charybdis 4-rc6
Simon Arlott [Sun, 6 Aug 2017 15:20:03 +0000 (16:20 +0100)]
tests: send1: add tag tests to all functions
Simon Arlott [Sun, 6 Aug 2017 11:05:24 +0000 (12:05 +0100)]
ircd: send tags on every message
Simplify linebuf by introducing fsnprint to manage a list of printfs.
Add a msgbuf unparse cache for send functions that loop.
Simon Arlott [Sun, 6 Aug 2017 12:30:47 +0000 (13:30 +0100)]
tests: send1: fix sendto_channel_opmod (remote) to cover all scenarios
Simon Arlott [Sun, 6 Aug 2017 12:14:12 +0000 (13:14 +0100)]
tests: send1: fix sendto_channel_opmod (remote) to call the right function
Simon Arlott [Sun, 6 Aug 2017 12:00:49 +0000 (13:00 +0100)]
tests: send1: add missing CAP_SERVER_TIME test to sendto_channel_flags from remote users
Simon Arlott [Sun, 6 Aug 2017 11:53:39 +0000 (12:53 +0100)]
tests: send1: test MODE_MODERATED with sendto_channel_opmod
Simon Arlott [Sun, 6 Aug 2017 10:05:03 +0000 (11:05 +0100)]
tests: send1: load modules in a predictable order
So that tags are added in the same order every time.
# wanted: @time=2017-07-14T02:40:00.000Z;account=test :LChanPeon!username@example.test TEST #placeholder :Hello World!
# seen: @account=test;time=2017-07-14T02:40:00.000Z :LChanPeon!username@example.test TEST #placeholder :Hello World!
Simon Arlott [Sun, 6 Aug 2017 00:42:51 +0000 (01:42 +0100)]
tests: add missing modules symlinks
Simon Arlott [Sun, 6 Aug 2017 00:12:59 +0000 (01:12 +0100)]
tests: add remaining sendto_* tests
Simon Arlott [Sat, 5 Aug 2017 21:34:17 +0000 (22:34 +0100)]
ircd: check caps for user in sendto_common_channels_local
Simon Arlott [Sat, 5 Aug 2017 15:54:44 +0000 (16:54 +0100)]
tests: add remote server message tests
Test sendto_one, sendto_one_prefix, sendto_one_notice and complete
sendto_one_numeric (for unregistered clients).
Simon Arlott [Sat, 5 Aug 2017 13:14:53 +0000 (14:14 +0100)]
tests: add client util make_local_person_oper()
Simon Arlott [Sat, 5 Aug 2017 13:09:01 +0000 (14:09 +0100)]
tests: add sendto_* test framework
Simon Arlott [Sat, 5 Aug 2017 11:29:52 +0000 (12:29 +0100)]
ircd: log command in mod_add_cmd/mod_del_cmd error scenarios
Simon Arlott [Sat, 5 Aug 2017 10:27:02 +0000 (11:27 +0100)]
ircd: substitution: fix buffer overrun if variable name is too long
Also fix the "ptr = ptr + (pptr - ptr)" aka "ptr = pptr" mess by
removing pptr.
Simon Arlott [Fri, 4 Aug 2017 20:01:17 +0000 (21:01 +0100)]
remove unused variables
Simon Arlott [Sat, 29 Jul 2017 19:29:24 +0000 (20:29 +0100)]
ssld: avoid clang static analysis warning
Edit by @aaronmdjones: fix for loop initialisation and inner condition
Simon Arlott [Fri, 4 Aug 2017 18:45:34 +0000 (19:45 +0100)]
tests: fix warnings
Simon Arlott [Fri, 4 Aug 2017 18:56:29 +0000 (19:56 +0100)]
remove unused variables
Simon Arlott [Tue, 1 Aug 2017 21:42:56 +0000 (22:42 +0100)]
m_webirc: set sockhost before potentially using it to set host
Remove extra IP check, it's not necessary.
Simon Arlott [Mon, 31 Jul 2017 06:58:06 +0000 (07:58 +0100)]
cap_server_time: check return values of string functions
Simon Arlott [Sun, 30 Jul 2017 21:03:23 +0000 (22:03 +0100)]
cap_server_time: provide time with millisecond resolution
Simon Arlott [Sun, 30 Jul 2017 17:43:52 +0000 (18:43 +0100)]
charybdis 4-rc5
Aaron Jones [Mon, 3 Jul 2017 00:12:47 +0000 (00:12 +0000)]
mbedtls.c: minor fixups
- Add (void) casts for unused function parameters
- Rearrange member in `struct rb_mbedtls_cfg_context' for data alignment
- Document a `clang-4.0 -Weverything' (-Wcast-qual) diagnostic
- Avoid pointless conversions between positive/negative error codes
- Use capital hexadecimals in error codes and properly cast to
(unsigned int) for %x/%X
Simon Arlott [Sun, 30 Jul 2017 17:04:38 +0000 (18:04 +0100)]
m_cap: use rn_snprintf_try_append
Simon Arlott [Sun, 30 Jul 2017 16:05:26 +0000 (17:05 +0100)]
tests: add rb_snprintf_append, rb_snprintf_try_append tests
Simon Arlott [Sun, 30 Jul 2017 16:04:06 +0000 (17:04 +0100)]
librb: add rb_snprintf_try_append
For when it might fit, or it might not.
Simon Arlott [Sun, 30 Jul 2017 16:03:30 +0000 (17:03 +0100)]
librb: rb_snprinf_append: handle error return value from vsnprintf()
Simon Arlott [Sun, 30 Jul 2017 14:56:29 +0000 (15:56 +0100)]
tests: add rb_linebuf_put tests
Simon Arlott [Sun, 30 Jul 2017 12:47:27 +0000 (13:47 +0100)]
librb: linebuf: reduce the number of "put" implementations from 4 to 1
Simon Arlott [Sat, 29 Jul 2017 22:51:54 +0000 (23:51 +0100)]
Revert "Core modules cannot be unloaded, otherwise bad things happen."
This reverts commit
b5cfad03195d566cd259154d212875fb238f5d80 .
Simon Arlott [Sat, 29 Jul 2017 22:19:24 +0000 (23:19 +0100)]
m_join: remove global variable parabuf
Simon Arlott [Sat, 29 Jul 2017 22:15:14 +0000 (23:15 +0100)]
m_join: remove global variable modebuf
Simon Arlott [Sat, 29 Jul 2017 22:11:36 +0000 (23:11 +0100)]
m_join: remove global variable para
Simon Arlott [Sat, 29 Jul 2017 22:10:35 +0000 (23:10 +0100)]
m_join: remove global variable pargs
Simon Arlott [Sat, 29 Jul 2017 22:09:16 +0000 (23:09 +0100)]
m_join: remove global variable mbuf
Simon Arlott [Sat, 29 Jul 2017 22:32:27 +0000 (23:32 +0100)]
librb: linebuf needs to use the buffer limit from msgbuf_unparse_prefix
Simon Arlott [Sat, 29 Jul 2017 22:24:23 +0000 (23:24 +0100)]
ircd: send: these buffers can be static
Simon Arlott [Sat, 29 Jul 2017 21:15:27 +0000 (22:15 +0100)]
m_cap: Fix CAP LS generation
The `caplen` variable was unused, so the cap to be output wasn't considered
when determining whether or not it would fit.
Simon Arlott [Sat, 29 Jul 2017 16:47:07 +0000 (17:47 +0100)]
librb: rb_rawbuf_length: do something if soft assert fails
correct the value of rb->len
Simon Arlott [Fri, 28 Jul 2017 17:34:46 +0000 (18:34 +0100)]
tests: add msgbuf_unparse tests
Simon Arlott [Thu, 27 Jul 2017 11:58:13 +0000 (12:58 +0100)]
tests: add substitution_parse tests
Simon Arlott [Wed, 26 Jul 2017 20:06:49 +0000 (21:06 +0100)]
tests: add msgbuf_parse tests
Simon Arlott [Wed, 28 Jun 2017 20:24:10 +0000 (21:24 +0100)]
msgbuf: correctly split buffers into IRCv3 tags and RFC1459 message data
Simon Arlott [Wed, 28 Jun 2017 19:40:03 +0000 (20:40 +0100)]
linebuf: increase buffer size to accommodate IRCv3 tags
Simon Arlott [Tue, 25 Jul 2017 20:02:45 +0000 (21:02 +0100)]
tests: add C TAP harness
Simon Arlott [Fri, 28 Jul 2017 20:50:16 +0000 (21:50 +0100)]
librb: remove unnecessary NULL from the end of rb_string_to_array output
Simon Arlott [Sat, 29 Jul 2017 19:26:21 +0000 (20:26 +0100)]
ircd: attach_conf: avoid clang static analysis warning
In the impossible scenario where ClassPtr(aconf) is NULL, reject the
client instead of dereferencing the NULL pointer.
Simon Arlott [Sat, 29 Jul 2017 16:37:53 +0000 (17:37 +0100)]
make soft asserts better by allowing them to be used in expressions
Simon Arlott [Sat, 29 Jul 2017 20:05:41 +0000 (21:05 +0100)]
wsockd: avoid clang static analysis warning
Don't set `x = 0` twice.
Simon Arlott [Sat, 29 Jul 2017 21:31:04 +0000 (22:31 +0100)]
authd: opm: avoid clang static analysis warning
Remove unused `c` variable.
Simon Arlott [Sat, 29 Jul 2017 19:45:53 +0000 (20:45 +0100)]
ircd: send_to_channel_flags: avoid clang static analysis warning
Set current_capmask and then use it, instead of referencing target_p->localClient->caps again.
This makes the purpose of current_capmask a bit clearer.
Simon Arlott [Sat, 29 Jul 2017 19:41:37 +0000 (20:41 +0100)]
ircd: sendto_one_notice: avoid clang static analysis warning
target_p->from can't be NULL, and if it is then get_id(..., target_p)
dereferences it later in the function anyway
Simon Arlott [Sat, 29 Jul 2017 19:35:54 +0000 (20:35 +0100)]
librb: rb_lib_loop: avoid clang static analysis warning
Simon Arlott [Sat, 29 Jul 2017 19:29:24 +0000 (20:29 +0100)]
ssld: avoid clang static analysis warning
Don't set `x = 0` twice.
Simon Arlott [Sat, 29 Jul 2017 19:16:59 +0000 (20:16 +0100)]
ircd: sendto_one_numeric: avoid clang static analysis warning
target_p->from can't be NULL, and if it is then get_id(..., target_p)
dereferences it later in the function anyway
Simon Arlott [Sat, 29 Jul 2017 19:16:26 +0000 (20:16 +0100)]
authd: opm: avoid clang static analysis warning
Remove unused `lookup` variables.
Simon Arlott [Sat, 29 Jul 2017 19:14:43 +0000 (20:14 +0100)]
ircd: get_or_create_channel: avoid clang static analysis warning
Use `len` after setting it.
Simon Arlott [Sat, 29 Jul 2017 18:45:07 +0000 (19:45 +0100)]
ssld: avoid clang static analysis warning
Simon Arlott [Sat, 29 Jul 2017 18:25:11 +0000 (19:25 +0100)]
ircd: sendto_one_prefix: avoid clang static analysis warning
target_p->from can't be NULL, and if it is then get_id(..., target_p)
dereferences it later in the function anyway
Simon Arlott [Sat, 29 Jul 2017 18:17:34 +0000 (19:17 +0100)]
exit_remote_server: avoid clang static analysis warning
if IsServer(source_p) then the following must be all non-NULL:
->serv
->servptr
->servptr->serv
Remove unnecessary and inconsistent pointer checks.
Simon Arlott [Sat, 29 Jul 2017 18:27:19 +0000 (19:27 +0100)]
librb: rb_linebuf_copy_raw: remove unused assignment
Simon Arlott [Sat, 29 Jul 2017 16:39:28 +0000 (17:39 +0100)]
ircd: hostmask: avoid clang static analysis warning
arec->Mask.ipa.bits is unused if arec->masktype == HM_HOST
Simon Arlott [Sat, 29 Jul 2017 20:38:34 +0000 (21:38 +0100)]
librb: commio: Must set addrlen before every call to accept()
If an IPv4 connection is dropped by the pre-callback, and there is a
pending IPv6 connection on the same listening socket then the retried
accept() will be unable to populate `st` because `addrlen` will be too
small. Also initialise `st` each time to avoid a clang static analysis
warning.
Simon Arlott [Sat, 29 Jul 2017 20:31:17 +0000 (21:31 +0100)]
ircd: listener: Document check_reject() behaviour
Simon Arlott [Sat, 29 Jul 2017 18:59:20 +0000 (19:59 +0100)]
wsockd: Initialise ws_frame_hdr_t before using it
Outgoing messages have uninitialised data from the stack in the 3 reserved
bits of the opcode_rsv_fin value.
Simon Arlott [Fri, 28 Jul 2017 20:28:44 +0000 (21:28 +0100)]
sslproc: check number of arguments to zipstats command
Aaron Jones [Wed, 5 Jul 2017 17:35:28 +0000 (17:35 +0000)]
src/channel.c: don't use the bancache in is_banned()/is_quieted()
The bancache will be re-architected onto clients in future for easier
invalidation, but this is a good-enough temporary fix for issue #243
Fixes #243
Simon Arlott [Thu, 27 Jul 2017 17:51:13 +0000 (18:51 +0100)]
Revert "no really, it's dead people"
This reverts commit
40ac82e87820d9941bdd38571d0390122008e5d3 .