]> jfr.im git - irc/charybdis-ircd/charybdis.git/log
irc/charybdis-ircd/charybdis.git
7 years agoMbedTLS: Forward-port release/3.5 improvements
Aaron Jones [Sat, 17 Sep 2016 17:19:31 +0000 (17:19 +0000)] 
MbedTLS: Forward-port release/3.5 improvements

The changes made in this file are detailed in release/3.5 commits
295c8f7d37bb557 through 265dc4e53c0b24e inclusive.

Some slight alterations are necessary; librb instead of libratbox,
snprintf() instead of rb_snprintf(), etc. Also, release/4 has
offline certificate digesting functionality. For more insight,
simply diff the mbedtls.c between release/3.5 and release/4.

7 years agoOpenSSL: Forward-port release/3.5 improvements
Aaron Jones [Sat, 17 Sep 2016 17:03:21 +0000 (17:03 +0000)] 
OpenSSL: Forward-port release/3.5 improvements

The changes made in this file are detailed in release/3.5 commits
1f30c8943bf2ca3 through 92c04c6b9dbdd11 inclusive.

Some slight alterations are necessary; librb instead of libratbox,
snprintf() instead of rb_snprintf(), etc. Also, release/4 has
offline certificate digesting functionality. For more insight,
simply diff the openssl.c between release/3.5 and release/4.

7 years agoircd: introduce 'no-export' links
William Pitcock [Fri, 16 Sep 2016 22:18:55 +0000 (17:18 -0500)] 
ircd: introduce 'no-export' links

Links that are 'no-export' are not distributed to the rest of the IRC network (including local peers).
This provides a core primitive for 'anycasting' services (but the actual issue of synchronizing data in
a services package is left to the authors of the services package).

7 years agohelpops: fix up graph cleanup for helpers_list
William Pitcock [Fri, 16 Sep 2016 22:02:50 +0000 (17:02 -0500)] 
helpops: fix up graph cleanup for helpers_list

7 years agoextensions/chantype_dummy: ^ is a valid nickchar, but > isn't
William Pitcock [Fri, 16 Sep 2016 19:12:29 +0000 (14:12 -0500)] 
extensions/chantype_dummy: ^ is a valid nickchar, but > isn't

7 years agoNEWS: document new CHANTYPES api
William Pitcock [Fri, 16 Sep 2016 19:08:04 +0000 (14:08 -0500)] 
NEWS: document new CHANTYPES api

7 years agoextensions/chantype_dummy: cleanups
William Pitcock [Fri, 16 Sep 2016 19:07:54 +0000 (14:07 -0500)] 
extensions/chantype_dummy: cleanups

7 years agochannels: fix IsChannelName() to actually use IsChanPrefix().
William Pitcock [Fri, 16 Sep 2016 19:02:41 +0000 (14:02 -0500)] 
channels: fix IsChannelName() to actually use IsChanPrefix().

7 years agosupported: fix up CHANTYPES
William Pitcock [Fri, 16 Sep 2016 19:00:00 +0000 (14:00 -0500)] 
supported: fix up CHANTYPES

7 years agoextensions: add new module adding ^channels (which are just like #channels)
William Pitcock [Fri, 16 Sep 2016 18:55:44 +0000 (13:55 -0500)] 
extensions: add new module adding ^channels (which are just like #channels)

7 years agosupported: add chantypes_update()
William Pitcock [Fri, 16 Sep 2016 18:49:02 +0000 (13:49 -0500)] 
supported: add chantypes_update()

7 years agomatch: allow the CharAttrs table to be modified at runtime
William Pitcock [Fri, 16 Sep 2016 18:09:44 +0000 (13:09 -0500)] 
match: allow the CharAttrs table to be modified at runtime

7 years agohelpops: MyClient() check is wrong, we only care if it is a Person or a Server
William Pitcock [Fri, 16 Sep 2016 17:57:34 +0000 (12:57 -0500)] 
helpops: MyClient() check is wrong, we only care if it is a Person or a Server

7 years agohelpops: handle cleaning up remote opers from the helpops list
William Pitcock [Fri, 16 Sep 2016 17:56:18 +0000 (12:56 -0500)] 
helpops: handle cleaning up remote opers from the helpops list

7 years agoMerge pull request #217 from Xenthys/release/4
William Pitcock [Fri, 16 Sep 2016 05:06:40 +0000 (22:06 -0700)] 
Merge pull request #217 from Xenthys/release/4

m_grant.c - fixed remote grant support

7 years agoAdd hooks for local and remote nick changes
Stephen Bennett [Sun, 9 Nov 2008 18:54:00 +0000 (18:54 +0000)] 
Add hooks for local and remote nick changes

7 years agomsgbuf: Fix remote crash vulnerability due to malformed message tag.
Aaron Jones [Sun, 11 Sep 2016 10:33:19 +0000 (10:33 +0000)] 
msgbuf: Fix remote crash vulnerability due to malformed message tag.

Fixes #218

Reported-by: ManiacTwister <redacted>
7 years agom_grant.c - fixed remote grant support
Xenthys [Sat, 10 Sep 2016 15:54:13 +0000 (17:54 +0200)] 
m_grant.c - fixed remote grant support

7 years agoMbedTLS: Misc backend cleanups
Aaron Jones [Sat, 10 Sep 2016 08:51:09 +0000 (08:51 +0000)] 
MbedTLS: Misc backend cleanups

This is a forward-port of release/3.5 commit 566f4678

* Add generic direction enum for negotiation setup.

* Rename a rather long wrapper function to a shorter one consistent with
  what it does.

* Rework context setup function.

* Don't check for handshake state before beginning handshaking.

  The old backend began a handshake and then stepped into the callback
  function if it was interrupted; the current one just jumps right into
  it, so there is no need to check if it has previously succeeded,
  because it hasn't been attempted yet.

* Add missing errno assignment to one of the handshake wrappers.

* Don't bother checking if SSL_P(F) is NULL when we already checked if
  F->ssl is NULL -- this should be impossible.

* Don't bother checking if SSL_C(F) is NULL -- this was a no-op.

* Change the socket send and recv functions to not peer into a foreign
  ratbox structure -- use the correct function to get the socket fd.

* Rewrap some lines and function arguments.

Other backends will be brought into line with this backend soon.

This will enable easier maintenance of the backends, by reducing the
diffs between them, which should make different behaviour easier to
spot.

7 years agoMbedTLS: Treat 0 bytes read/written to socket properly
Aaron Jones [Fri, 9 Sep 2016 01:46:20 +0000 (01:46 +0000)] 
MbedTLS: Treat 0 bytes read/written to socket properly

At the moment, if a link quits in just the right (wrong [1]) way,
the quit reason will resemble:

    <-- foo (~bar@baz) has quit (Read error: (-0x0) )

This should resolve that.

[1] Peers should send a close_notify alert before abruptly shutting
    down their socket. This will result in a sane quit message:

    <-- foo (~bar@baz) has quit (Read error: (-0x7880) SSL -
    The peer notified us that the connection is going to be closed)

[ci skip]

7 years agoMbedTLS: Initial attempt to port release/3.5 commit 89d4c468 to this branch
Aaron Jones [Sun, 4 Sep 2016 03:50:29 +0000 (03:50 +0000)] 
MbedTLS: Initial attempt to port release/3.5 commit 89d4c468 to this branch

7 years agoSASL: Disallow beginning : and space anywhere in AUTHENTICATE parameter
Aaron Jones [Sat, 3 Sep 2016 17:29:53 +0000 (17:29 +0000)] 
SASL: Disallow beginning : and space anywhere in AUTHENTICATE parameter

This is a FIX FOR A SECURITY VULNERABILITY. All Charybdis users must
apply this fix if you support SASL on your servers, or unload m_sasl.so
in the meantime.

7 years agoircd: serv_connect: initialise sa_connect/sa_bind to AF_UNSPEC
Simon Arlott [Sat, 3 Sep 2016 13:50:59 +0000 (14:50 +0100)] 
ircd: serv_connect: initialise sa_connect/sa_bind to AF_UNSPEC

These are read to check if they're AF_UNSPEC (unset) but they aren't
initialised.

7 years agolibrb: set sockaddr port to 0 in success path
Simon Arlott [Sat, 3 Sep 2016 13:36:17 +0000 (14:36 +0100)] 
librb: set sockaddr port to 0 in success path

Instead of only in the failure path, which causes
all sorts of annoying server connection failures
when we try to repeatedly reuse the same port.

7 years agoOpenSSL: Initialise if LibreSSL
Aaron Jones [Thu, 1 Sep 2016 19:29:47 +0000 (19:29 +0000)] 
OpenSSL: Initialise if LibreSSL

LibreSSL's definition of OPENSSL_VERSION_NUMBER bites us in the ass,
*again*.

7 years agoOpenSSL: Initialise one context at a time
Aaron Jones [Tue, 30 Aug 2016 10:30:17 +0000 (10:30 +0000)] 
OpenSSL: Initialise one context at a time

If initialising the server context fails, but the client one succeeds,
we will not only leak memory, but the error message reported for
initialising the server context might not make sense, because we
initialise the client context after and that could erase or change the
list of queued errors.

This scenario is considered rare. Nevertheless, we now initialise the
client context after *successfully* initialising the server context.

7 years agoPrint initialisation notice before forking
Aaron Jones [Wed, 24 Aug 2016 16:44:04 +0000 (16:44 +0000)] 
Print initialisation notice before forking

7 years agoircd: Fix umode orphan scheme.
Jason Volk [Wed, 24 Aug 2016 13:14:47 +0000 (06:14 -0700)] 
ircd: Fix umode orphan scheme.

Cherry-picked from jevolk/charybdis f5e7f335
Reformatted slightly.

7 years agostartup: fork before initialising the event subsystem
Aaron Jones [Sun, 21 Aug 2016 22:29:16 +0000 (22:29 +0000)] 
startup: fork before initialising the event subsystem

On FreeBSD 4.8, fork(2) doesn't actually behave like fork(2).

Namely, kqueue(2) descriptors are not inherited by the child.
IOW, we can't fork(2) after we get the kqueue(2) descriptor.

So we'll just have to rely on people to actually read the
server log file if they want to understand why their server
is dying during startup.

7 years agoAttempt to open /dev/null before forking incase it would fail
Aaron Jones [Sun, 21 Aug 2016 00:32:34 +0000 (00:32 +0000)] 
Attempt to open /dev/null before forking incase it would fail

7 years agoAttempt #2 at fixing the file descriptor mess.
Aaron Jones [Sun, 21 Aug 2016 00:15:17 +0000 (00:15 +0000)] 
Attempt #2 at fixing the file descriptor mess.

This commit defers daemonisation to the end of initialisation
as that makes it vastly simpler to get this right.

7 years agoRevert "ircd startup: avoid black magic with file descriptors"
Aaron Jones [Sat, 20 Aug 2016 22:22:37 +0000 (22:22 +0000)] 
Revert "ircd startup: avoid black magic with file descriptors"

This reverts commit 27c0f6d8f406658655cc45a0a7f2d0a0f120244b.

A more extensive investigation and refactoring of the code is
necessary.

7 years agoircd startup: avoid black magic with file descriptors
Aaron Jones [Sat, 20 Aug 2016 21:14:53 +0000 (21:14 +0000)] 
ircd startup: avoid black magic with file descriptors

This *should* fix a reported but as yet unreproducable
ircd abort on restart.

7 years agoircd: Allow non-default CAP_MASK during server estab.
Jason Volk [Sat, 20 Aug 2016 11:10:28 +0000 (04:10 -0700)] 
ircd: Allow non-default CAP_MASK during server estab.

7 years agoTLS Backends: Harmomise the rb_ssl_get_cipher() function
Aaron Jones [Sat, 20 Aug 2016 03:16:33 +0000 (04:16 +0100)] 
TLS Backends: Harmomise the rb_ssl_get_cipher() function

The GNUTLS backend reports the version in use for the client as well
as its ciphersuite -- do the same for the other 2 backends.

7 years agoGNUTLS: Avoid null dereference in constructing ciphersuite
Aaron Jones [Fri, 19 Aug 2016 20:26:43 +0000 (20:26 +0000)] 
GNUTLS: Avoid null dereference in constructing ciphersuite

7 years agoGNUTLS: Cleanup fingerprint generation
Aaron Jones [Fri, 19 Aug 2016 19:14:40 +0000 (19:14 +0000)] 
GNUTLS: Cleanup fingerprint generation

Removes intermediate buffer, properly check return values

7 years agoREADME: Clarify that OpenSSL is not required for ECDHE
Aaron Jones [Mon, 15 Aug 2016 10:50:59 +0000 (10:50 +0000)] 
README: Clarify that OpenSSL is not required for ECDHE

7 years agomkpasswd: use urandom for salts, cleanup
Aaron Jones [Mon, 15 Aug 2016 09:50:53 +0000 (09:50 +0000)] 
mkpasswd: use urandom for salts, cleanup

Using /dev/random for salt generation is pointless -- it can block, and
any extra randomness it would provide (which is debatable) is not needed,
as salts only need to be unique, not unpredictable.

7 years agoopenssl: Avoid use-after-free when rehashing fails to load new files
Aaron Jones [Fri, 12 Aug 2016 13:34:13 +0000 (13:34 +0000)] 
openssl: Avoid use-after-free when rehashing fails to load new files

Commit cf12678 introduced a fix for issue #186 by freeing the old SSL_CTX
structure before constructing a new one, which could disconnect existing
clients otherwise.

Unfortunately, the freeing is done first, which means that if setting up
a new structure fails for any reason, there will be no usable structures
left, but they are still referenced.

This fix moves the freeing to the end of the function, using intermediate
new variables in the meantime. This problem was discovered while testing
against OpenSSL 1.1.0 RC6.

7 years agocharybdis 4-rc3. charybdis-4-rc3
William Pitcock [Sat, 6 Aug 2016 04:38:34 +0000 (23:38 -0500)] 
charybdis 4-rc3.

7 years agom_grant: convert jevolk's rewritten version to AV2
William Pitcock [Sat, 6 Aug 2016 04:37:05 +0000 (23:37 -0500)] 
m_grant: convert jevolk's rewritten version to AV2

7 years agoMerge pull request #207 from charybdis-ircd/jevolk-patch-1
William Pitcock [Sat, 6 Aug 2016 04:07:00 +0000 (23:07 -0500)] 
Merge pull request #207 from charybdis-ircd/jevolk-patch-1

authd: Fix use after reference count decrement.

7 years agoauthd: Fix use after reference count decrement.
Jason Volk [Fri, 5 Aug 2016 19:08:16 +0000 (13:08 -0600)] 
authd: Fix use after reference count decrement.

7 years agoMerge pull request #205 from jevolk/release/4
William Pitcock [Wed, 27 Jul 2016 07:34:38 +0000 (02:34 -0500)] 
Merge pull request #205 from jevolk/release/4

m_grant: rewrite.

7 years agom_grant: rewrite.
Jason Volk [Wed, 27 Jul 2016 05:40:26 +0000 (22:40 -0700)] 
m_grant: rewrite.

7 years agoircd: Fix missing operhash reference decrement from b02a913b.
Jason Volk [Tue, 19 Jul 2016 22:59:35 +0000 (15:59 -0700)] 
ircd: Fix missing operhash reference decrement from b02a913b.

7 years agoFix erroneous return value.
Jason Volk [Sat, 16 Jul 2016 18:26:38 +0000 (11:26 -0700)] 
Fix erroneous return value.

7 years agoreference.conf: Document fingerprint generation
Aaron Jones [Sat, 16 Jul 2016 05:41:49 +0000 (05:41 +0000)] 
reference.conf: Document fingerprint generation

[ci skip]

7 years agoFix stupid compiler errors by my stupidity and tiredness
Elizabeth Myers [Tue, 28 Jun 2016 00:14:32 +0000 (19:14 -0500)] 
Fix stupid compiler errors by my stupidity and tiredness

7 years agoblacklist: add blacklist_cancel_none
Elizabeth Myers [Tue, 28 Jun 2016 00:06:49 +0000 (19:06 -0500)] 
blacklist: add blacklist_cancel_none

7 years agoblacklist: add return statement. d'oh.
Elizabeth Myers [Tue, 28 Jun 2016 00:00:00 +0000 (19:00 -0500)] 
blacklist: add return statement. d'oh.

7 years agoblacklist: fix precedence lossage
Elizabeth Myers [Mon, 27 Jun 2016 23:59:53 +0000 (18:59 -0500)] 
blacklist: fix precedence lossage

7 years agoblacklist: if no blacklists were checked, properly terminate query.
Elizabeth Myers [Mon, 27 Jun 2016 23:56:14 +0000 (18:56 -0500)] 
blacklist: if no blacklists were checked, properly terminate query.

7 years agobuild_rdns: minor cleanup
Elizabeth Myers [Mon, 27 Jun 2016 23:37:46 +0000 (18:37 -0500)] 
build_rdns: minor cleanup

7 years agoblacklist: tweak message for timeout
Elizabeth Myers [Mon, 27 Jun 2016 23:28:02 +0000 (18:28 -0500)] 
blacklist: tweak message for timeout

7 years agoblacklist: give different messages for cancellation and timeout
Elizabeth Myers [Mon, 27 Jun 2016 23:24:39 +0000 (18:24 -0500)] 
blacklist: give different messages for cancellation and timeout

7 years agocharybdis 4-rc2. charybdis-4-rc2
William Pitcock [Sun, 26 Jun 2016 03:10:41 +0000 (22:10 -0500)] 
charybdis 4-rc2.

7 years agoMerge branch 'master' into release/4
William Pitcock [Sat, 25 Jun 2016 19:27:44 +0000 (14:27 -0500)] 
Merge branch 'master' into release/4

7 years agoFix bug. Note: The second hunk is just an assumption. It's not called from anywhere.
Jason Volk [Sat, 25 Jun 2016 02:29:02 +0000 (19:29 -0700)] 
Fix bug. Note: The second hunk is just an assumption. It's not called from anywhere.

7 years agoMerge pull request #196 from jevolk/master
William Pitcock [Wed, 22 Jun 2016 01:00:01 +0000 (20:00 -0500)] 
Merge pull request #196 from jevolk/master

I typed MODRESTART by accident

7 years agoCore modules cannot be unloaded, otherwise bad things happen.
Jason Volk [Wed, 22 Jun 2016 00:39:44 +0000 (17:39 -0700)] 
Core modules cannot be unloaded, otherwise bad things happen.
Additionally some information is logged and passed to the operator
conducting a MODRESTART.

7 years agoircd: Fix capability entry name string ownership.
Jason Volk [Wed, 22 Jun 2016 00:32:28 +0000 (17:32 -0700)] 
ircd: Fix capability entry name string ownership.
The entry->cap must be copied and exclusive to the entry for the
cap to be orphaned, even if literals are expected. Because modules.

7 years agocharybdis 4-rc1.
William Pitcock [Mon, 20 Jun 2016 03:44:47 +0000 (22:44 -0500)] 
charybdis 4-rc1.

7 years agoMerge branch 'master' into release/4
William Pitcock [Mon, 20 Jun 2016 02:49:52 +0000 (21:49 -0500)] 
Merge branch 'master' into release/4

7 years agolibrb: remove one more VMS detritius
William Pitcock [Mon, 20 Jun 2016 02:47:59 +0000 (21:47 -0500)] 
librb: remove one more VMS detritius

7 years agolibrb: we have no plans to support VMS
William Pitcock [Mon, 20 Jun 2016 02:47:23 +0000 (21:47 -0500)] 
librb: we have no plans to support VMS

7 years agoMerge branch 'master' into release/4
William Pitcock [Sat, 18 Jun 2016 06:06:52 +0000 (01:06 -0500)] 
Merge branch 'master' into release/4

7 years agoircd: relocate_paths() back on windows only now
William Pitcock [Sat, 18 Jun 2016 06:05:38 +0000 (01:05 -0500)] 
ircd: relocate_paths() back on windows only now

7 years agom_modules: use new module api
William Pitcock [Sat, 18 Jun 2016 05:59:15 +0000 (00:59 -0500)] 
m_modules: use new module api

7 years agoconf_parser: warning fixes
William Pitcock [Sat, 18 Jun 2016 05:52:54 +0000 (00:52 -0500)] 
conf_parser: warning fixes

7 years agomodules: serious cleanups
William Pitcock [Sat, 18 Jun 2016 05:52:16 +0000 (00:52 -0500)] 
modules: serious cleanups

7 years agomodules: cleanups
William Pitcock [Sat, 18 Jun 2016 05:38:40 +0000 (00:38 -0500)] 
modules: cleanups

7 years agoircd: fix compile of relocate_paths()
William Pitcock [Sat, 18 Jun 2016 05:22:02 +0000 (00:22 -0500)] 
ircd: fix compile of relocate_paths()

7 years agoircd: make relocate_paths() available always
William Pitcock [Sat, 18 Jun 2016 05:21:39 +0000 (00:21 -0500)] 
ircd: make relocate_paths() available always

7 years agoircd: call relocate_paths() in all cases
William Pitcock [Sat, 18 Jun 2016 05:20:59 +0000 (00:20 -0500)] 
ircd: call relocate_paths() in all cases

7 years agomessages: fix format string warning reported by latest clang
William Pitcock [Sat, 18 Jun 2016 04:39:19 +0000 (23:39 -0500)] 
messages: fix format string warning reported by latest clang

7 years agoircd: print runtime path configuration
William Pitcock [Sat, 18 Jun 2016 04:36:47 +0000 (23:36 -0500)] 
ircd: print runtime path configuration

7 years agolibrb: dictionaries which use integer keys may use 0 legitimately
William Pitcock [Sat, 18 Jun 2016 04:29:11 +0000 (23:29 -0500)] 
librb: dictionaries which use integer keys may use 0 legitimately

7 years agoinvite: do not send duplicate invite messages (closes #194)
William Pitcock [Fri, 17 Jun 2016 01:20:50 +0000 (20:20 -0500)] 
invite: do not send duplicate invite messages (closes #194)

7 years agoinvite: do not send duplicate invite messages (closes #194)
William Pitcock [Fri, 17 Jun 2016 01:20:50 +0000 (20:20 -0500)] 
invite: do not send duplicate invite messages (closes #194)

7 years agombedtls backend: indicate reason for TLS session termination
Aaron Jones [Sun, 12 Jun 2016 11:33:06 +0000 (11:33 +0000)] 
mbedtls backend: indicate reason for TLS session termination

[ci skip]

7 years agombedtls backend: indicate reason for TLS session termination
Aaron Jones [Sun, 12 Jun 2016 11:33:06 +0000 (11:33 +0000)] 
mbedtls backend: indicate reason for TLS session termination

[ci skip]

8 years agoCREDITS: charybdis official channel will now be on irc.charybdis.io.
William Pitcock [Sun, 5 Jun 2016 04:53:21 +0000 (23:53 -0500)] 
CREDITS: charybdis official channel will now be on irc.charybdis.io.

8 years agoCREDITS: charybdis official channel will now be on irc.charybdis.io.
William Pitcock [Sun, 5 Jun 2016 04:53:21 +0000 (23:53 -0500)] 
CREDITS: charybdis official channel will now be on irc.charybdis.io.

8 years agoCREDITS: adjust to reflect present situation
William Pitcock [Sun, 5 Jun 2016 04:47:47 +0000 (23:47 -0500)] 
CREDITS: adjust to reflect present situation

8 years agoCREDITS: adjust to reflect present situation
William Pitcock [Sun, 5 Jun 2016 04:47:47 +0000 (23:47 -0500)] 
CREDITS: adjust to reflect present situation

8 years agoFix regression introduced by commit 2f361bfc
Aaron Jones [Wed, 1 Jun 2016 21:04:45 +0000 (21:04 +0000)] 
Fix regression introduced by commit 2f361bfc

8 years agoFix regression introduced by commit 1863a0f8
Aaron Jones [Wed, 1 Jun 2016 21:03:46 +0000 (21:03 +0000)] 
Fix regression introduced by commit 1863a0f8

8 years agoPreliminary code tidying complete.
Aaron Jones [Wed, 1 Jun 2016 20:55:32 +0000 (20:55 +0000)] 
Preliminary code tidying complete.

These issues (commits 47a66e15 through 906fd91f inclusive) were
identified with the Clang compiler. Please raise concerns about
them on the issue tracker or in the support channel.

8 years agotools/mkfingerprint: strlen(3) on a raw byte array is wrong -- use its length as...
Aaron Jones [Wed, 1 Jun 2016 20:41:03 +0000 (20:41 +0000)] 
tools/mkfingerprint: strlen(3) on a raw byte array is wrong -- use its length as indicated by the function that filled it

8 years agotools/mkpasswd: functions that call exit(3) should be marked noreturn
Aaron Jones [Wed, 1 Jun 2016 20:38:54 +0000 (20:38 +0000)] 
tools/mkpasswd: functions that call exit(3) should be marked noreturn

8 years agobandb/bandb: functions that call exit(3) should be marked noreturn, avoid sign overfl...
Aaron Jones [Wed, 1 Jun 2016 20:37:51 +0000 (20:37 +0000)] 
bandb/bandb: functions that call exit(3) should be marked noreturn, avoid sign overflow in integer function argument

8 years agobandb/bantool: a function that calls exit(3) should be marked noreturn
Aaron Jones [Wed, 1 Jun 2016 20:34:51 +0000 (20:34 +0000)] 
bandb/bantool: a function that calls exit(3) should be marked noreturn

8 years agoauthd/res: make function used only within this unit static, remove unused macros
Aaron Jones [Wed, 1 Jun 2016 20:32:12 +0000 (20:32 +0000)] 
authd/res: make function used only within this unit static, remove unused macros

8 years agoauthd/provider: remove shadowed double variable decl
Aaron Jones [Wed, 1 Jun 2016 20:29:35 +0000 (20:29 +0000)] 
authd/provider: remove shadowed double variable decl

8 years agoauthd/authd: a function that calls exit(3) should be marked noreturn
Aaron Jones [Wed, 1 Jun 2016 20:27:19 +0000 (20:27 +0000)] 
authd/authd: a function that calls exit(3) should be marked noreturn

8 years agowsockd: various fixes
Aaron Jones [Wed, 1 Jun 2016 20:23:13 +0000 (20:23 +0000)] 
wsockd: various fixes

* Use correct sign for comparing data lengths
* Don't return a void statement in a void function
* Remove unused functions and macros

8 years agossld: remove unused macros, avoid sign overflow in integer function argument
Aaron Jones [Wed, 1 Jun 2016 20:17:09 +0000 (20:17 +0000)] 
ssld: remove unused macros, avoid sign overflow in integer function argument

8 years agowsproc: compile out dead code
Aaron Jones [Wed, 1 Jun 2016 20:15:07 +0000 (20:15 +0000)] 
wsproc: compile out dead code

Investigation is required to determine if this function should
actually be used