projects / irc.git / blame
| Commit | Line | Data |
|---|---|---|
| 3bd189cb JR |
1 | <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> |
| 2 | <HTML> | |
| 3 | <HEAD> | |
| 4 | <TITLE> [IRCServices Coding] Services 5.0 alpha 9 released | |
| 5 | </TITLE> | |
| 6 | <LINK REL="Index" HREF="index.html" > | |
| 7 | <LINK REL="made" HREF="mailto:ircservices-coding%40ircservices.za.net?Subject=%5BIRCServices%20Coding%5D%20Services%205.0%20alpha%209%20released&In-Reply-To="> | |
| 8 | <META NAME="robots" CONTENT="index,nofollow"> | |
| 9 | <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> | |
| 10 | <LINK REL="Previous" HREF="000071.html"> | |
| 11 | <LINK REL="Next" HREF="000069.html"> | |
| 12 | </HEAD> | |
| 13 | <BODY BGCOLOR="#ffffff"> | |
| 14 | <H1>[IRCServices Coding] Services 5.0 alpha 9 released</H1> | |
| 15 | <B>Andrew Church</B> | |
| 16 | <A HREF="mailto:ircservices-coding%40ircservices.za.net?Subject=%5BIRCServices%20Coding%5D%20Services%205.0%20alpha%209%20released&In-Reply-To=" | |
| 17 | TITLE="[IRCServices Coding] Services 5.0 alpha 9 released">achurch at achurch.org | |
| 18 | </A><BR> | |
| 19 | <I>Wed Dec 26 03:08:51 PST 2001</I> | |
| 20 | <P><UL> | |
| 21 | <LI>Previous message: <A HREF="000071.html">[IRCServices Coding] More bugs... :) | |
| 22 | </A></li> | |
| 23 | <LI>Next message: <A HREF="000069.html">[IRCServices Coding] Services 5.0 alpha 9 released | |
| 24 | </A></li> | |
| 25 | <LI> <B>Messages sorted by:</B> | |
| 26 | <a href="date.html#68">[ date ]</a> | |
| 27 | <a href="thread.html#68">[ thread ]</a> | |
| 28 | <a href="subject.html#68">[ subject ]</a> | |
| 29 | <a href="author.html#68">[ author ]</a> | |
| 30 | </LI> | |
| 31 | </UL> | |
| 32 | <HR> | |
| 33 | <!--beginarticle--> | |
| 34 | <PRE>><i>I was playing with the httpd/dbaccess/xml-export module, and IE6's | |
| 35 | </I>><i>usually annoying XML syntax checking pointed something out. Where | |
| 36 | </I>><i>there's an ampersand in a last_quit field, it replaces it with | |
| 37 | </I>><i>"&amp-" as opposed to the correct "&amp;", which causes IE to choke | |
| 38 | </I>>:<i>). The context is as follows: | |
| 39 | </I>><i> | |
| 40 | </I>><i><nickinfo> | |
| 41 | </I>><i><nick>[nick]</nick> | |
| 42 | </I>><i>... | |
| 43 | </I>><i><last_quit>Quit: Peace &amp- Protection 4.06</last_quit> | |
| 44 | </I>><i>... | |
| 45 | </I>><i><nickinfo> | |
| 46 | </I> | |
| 47 | Okay, that was a stupid one... an off-by-one error in a memcpy() size | |
| 48 | argument. Fixed, thanks; the patch is as follows: | |
| 49 | ||
| 50 | --------------------------------------------------------------------------- | |
| 51 | --- modules/misc/xml-export.c 19 Dec 2001 16:35:13 -0000 2.2 | |
| 52 | +++ modules/misc/xml-export.c 25 Dec 2001 18:12:42 -0000 2.3 | |
| 53 | @@ -94,7 +94,7 @@ | |
| 54 | d += 4; | |
| 55 | break; | |
| 56 | case '&': | |
| 57 | - memcpy(d, "&amp;", 4); | |
| 58 | + memcpy(d, "&amp;", 5); | |
| 59 | d += 5; | |
| 60 | break; | |
| 61 | default: | |
| 62 | --------------------------------------------------------------------------- | |
| 63 | ||
| 64 | ><i>Also, it seems to pad every <supass> or <pass> field with lots of | |
| 65 | </I>><i>"&#0;" null chars: | |
| 66 | </I>><i><supass>mysupass&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;& | |
| 67 | </I>><i>#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;</supass> | |
| 68 | </I>><i><pass>&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0 | |
| 69 | </I>><i>;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;&#0;</pa | |
| 70 | </I>><i>ss> | |
| 71 | </I> | |
| 72 | This is because the export-xml module can't know that the encryption | |
| 73 | module (if one is in use) uses a null character as a string terminator. | |
| 74 | In point of fact, the MD5 encryption module stores the passwords as 16 raw | |
| 75 | bytes rather than 32 hex characters, so null characters can very possibly | |
| 76 | appear in the middle of a password. Thus, passwords are stored as raw | |
| 77 | buffers of data (properly XML-encoded). | |
| 78 | ||
| 79 | ><i>Also, on my #chat channel on the v4 installation, Voice is set to | |
| 80 | </I>><i>level 0, so everyone is voiced when they join. However, when my AOPs | |
| 81 | </I>><i>join #chat on the v5 net, they get set +hq, and normal users don't | |
| 82 | </I>><i>get anything, which is rather odd (possibly to do with me not running | |
| 83 | </I>><i>the xOP module or something...). I'm continuing to investigate this | |
| 84 | </I>><i>one. | |
| 85 | </I> | |
| 86 | You should probably look into what check_access_cumode() | |
| 87 | (modules/chanserv/access.c) is doing; that part of the code has been | |
| 88 | thoroughly redone and gotten almost no testing. I'm not sure what would | |
| 89 | cause the autovoice level to get set to 0. | |
| 90 | ||
| 91 | --Andrew Church | |
| 92 | <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices-coding">achurch at achurch.org</A> | |
| 93 | <A HREF="http://achurch.org/">http://achurch.org/</A> | |
| 94 | ||
| 95 | </PRE> | |
| 96 | ||
| 97 | <!--endarticle--> | |
| 98 | <HR> | |
| 99 | <P><UL> | |
| 100 | <!--threads--> | |
| 101 | <LI>Previous message: <A HREF="000071.html">[IRCServices Coding] More bugs... :) | |
| 102 | </A></li> | |
| 103 | <LI>Next message: <A HREF="000069.html">[IRCServices Coding] Services 5.0 alpha 9 released | |
| 104 | </A></li> | |
| 105 | <LI> <B>Messages sorted by:</B> | |
| 106 | <a href="date.html#68">[ date ]</a> | |
| 107 | <a href="thread.html#68">[ thread ]</a> | |
| 108 | <a href="subject.html#68">[ subject ]</a> | |
| 109 | <a href="author.html#68">[ author ]</a> | |
| 110 | </LI> | |
| 111 | </UL> | |
| 112 | ||
| 113 | </body></html> |