X-Git-Url: https://jfr.im/git/erebus.git/blobdiff_plain/6b2c681d29a7f4d3157498b491bdb8371dad4c39..4fa1118bf7ba25a74d1443c562b98c11675d2c7c:/bot.py

diff --git a/bot.py b/bot.py
index 09df1db..2c214c7 100644
--- a/bot.py
+++ b/bot.py
@@ -15,23 +15,11 @@ class Bot(object):
 		self.user = user
 		self.realname = realname
 
-		self.chans = []
-
-		chcurs = self.parent.db.cursor()
-		chcurs.execute("SELECT chname FROM chans WHERE bot = %s AND active = 1", (self.nick,))
-		chans = chcurs.fetchall()
-		chcurs.close()
-
-		for chrow in chans:
-			uscurs = self.parent.db.cursor()
-			uscurs.execute("SELECT user, level FROM chusers WHERE chan = %s", (chrow['chname'],))
-			usrow = uscurs.fetchone()
-			levels = {}
-			while usrow is not None:
-				levels[usrow['user']] = -usrow['level']
-				usrow = uscurs.fetchone()
-			uscurs.close()
-			self.chans.append(self.parent.newchannel(self, chrow['chname'], levels))
+		curs = self.parent.db.cursor()
+		if curs.execute("SELECT chname FROM chans WHERE bot = %s AND active = 1", (self.nick,)):
+			chansres = curs.fetchall()
+			curs.close()
+			self.chans = [self.parent.newchannel(self, row['chname']) for row in chansres]
 
 		self.conn = BotConnection(self, bind, server, port)
 	def connect(self):
@@ -72,8 +60,7 @@ class Bot(object):
 			qt = pieces[3]
 			nick = pieces[4]
 			auth = pieces[5]
-			if auth != '0':
-				self.parent.user(nick).authed(auth)
+			self.parent.user(nick).authed(auth)
 
 		elif pieces[1] == "JOIN":
 			nick = pieces[0].split('!')[0][1:]
@@ -88,6 +75,9 @@ class Bot(object):
 			
 	def parsemsg(self, user, target, msg):
 		chan = None
+		if len(msg) == 0:
+			return
+
 		triggerused = msg[0] == self.parent.trigger
 		if triggerused: msg = msg[1:]
 		pieces = msg.split()
@@ -97,16 +87,20 @@ class Bot(object):
 				chanword = pieces[1]
 				if chanword[0] == '#':
 					chan = self.parent.channel(chanword)
-					pieces.pop(1)
+					if chan is not None: #if chan is still none, there's no bot on "chanword", and chanword is used as a parameter.
+						pieces.pop(1)
 
 		else: # message was sent to a channel
 			chan = self.parent.channel(target) #TODO check if bot's on channel --- in Erebus.channel() maybe?
-			if msg[0] == '*': # message may be addressed to bot by "*BOTNICK" trigger?
-				if pieces[0][1:].lower() == self.nick.lower():
-					pieces.pop(0) # command actually starts with next word
-					msg = ' '.join(pieces) # command actually starts with next word
-			elif not triggerused:
-				return # not to bot, don't process!
+			try:
+				if msg[0] == '*': # message may be addressed to bot by "*BOTNICK" trigger?
+					if pieces[0][1:].lower() == self.nick.lower():
+						pieces.pop(0) # command actually starts with next word
+						msg = ' '.join(pieces) # command actually starts with next word
+				elif not triggerused:
+					return # not to bot, don't process!
+			except IndexError:
+				return # Fix if you feel like it /BiohZn
 
 		cmd = pieces[0].lower()
 
@@ -114,17 +108,14 @@ class Bot(object):
 			for callback in self.parent.gethook(cmd):
 				if chan is None and callback.needchan:
 					self.msg(user, "You need to specify a channel for that command.")
-					continue
-				if user.glevel >= callback.reqglevel:
-					#TODO TODO TODO check reqclevel
+				elif user.glevel >= callback.reqglevel and (not callback.needchan or chan.levelof(user.auth) >= callback.reqclevel):
 					cbret = callback(self, user, chan, target, *pieces[1:])
 					if cbret is NotImplemented:
 						self.msg(user, "Command not implemented.")
-					continue
-		else:
-			self.msg(user, "No such command, or you don't have access.")
 
 	def msg(self, target, msg):
+		if target is None or msg is None: return
+
 		if isinstance(target, self.parent.User): self.conn.send("NOTICE %s :%s" % (target.nick, msg))
 		elif isinstance(target, self.parent.Channel): self.conn.send("PRIVMSG %s :%s" % (target.name, msg))
 		elif isinstance(target, basestring):
@@ -174,7 +165,7 @@ class BotConnection(object):
 
 	#TODO: rewrite send() to queue
 	def send(self, line):
-		print self.parent.nick, '[O]', line
+		print self.parent.nick, '[O]', str(line)
 		self.write(line)
 
 	def write(self, line):