help - dont allow args to SHOWCOMMANDS

[erebus.git] / bot.py

diff --git a/bot.py b/bot.py
index 793e27f6b6c923ad162e0f70ee41317c105a40b1..c727d7257810a47f108792ec4fcc62823f165f35 100644 (file)
--- a/bot.py
+++ b/bot.py
@@ -69,7 +69,11 @@ class Bot(object):
        def watchdog(self):
                if time.time() > int(self.parent.cfg.get('watchdog', 'maxtime', default=300))+self.lastreceived:
                        self.parse("ERROR :Fake-error from watchdog timer.")
-               self.watchdogtimer = MyTimer(int(self.parent.cfg.get('watchdog', 'interval', default=30)), self.watchdog)
+               if self.conn.registered():
+                       self.conn.send("PING :%s" % (time.time()))
+                       self._checknick()
+               watchdogtimer = MyTimer(int(self.parent.cfg.get('watchdog', 'interval', default=30)), self.watchdog)
+               watchdogtimer.start()
 
        def log(self, *args, **kwargs):
                self.parent.log(self.nick, *args, **kwargs)
@@ -77,11 +81,16 @@ class Bot(object):
        def connect(self):
                self.log('!', "Connecting")
                if self.conn.connect():
+                       self.log('!', "Connected")
                        self.parent.newfd(self, self.conn.socket.fileno())
 
        def getdata(self):
-               self.lastreceived = time.time()
-               return self.conn.read()
+               try:
+                       recvd = self.conn.read()
+                       self.lastreceived = time.time()
+                       return recvd
+               except EOFError as e:
+                       return [":%s ERROR :%s%r" % (self.nick, e.__class__.__name__, e.args)]
 
        def _checknick(self): # check if we're using the right nick, try changing
                if self.nick != self.permnick and self.conn.registered():
@@ -98,7 +107,7 @@ class Bot(object):
                        numeric = pieces[0]
 
                # dispatch dict
-               dispatch = { #things to look for after source
+               dispatch = {
                        'NOTICE': self._gotconnected,
                        '001': self._got001,
                        '004': self._got004,
@@ -138,14 +147,19 @@ class Bot(object):
                self._checknick()
        def _goterror(self, pieces):
                # TODO: better handling, just reconnect that single bot
+               error = ' '.join(pieces)
+               try:
+                       raise Exception(error)
+               except Exception as e:
+                       self.parent.mustquit = e
                try:
-                       self.quit("Error detected: %s" % ' '.join(pieces))
+                       self.quit("Error detected: %s" % (error))
                except: pass
                try:
                        curs = self.parent.query("UPDATE bots SET connected = 0")
                        curs.close()
                except: pass
-               os._exit(2) # can't use sys.exit since we might be in a sub-thread
+               self.log('!', 'Bot exiting due to: %s' % (error))
        def _got001(self, pieces):
                # We wait until the end of MOTD instead to consider ourselves registered, but consider uptime as of 001
                self.connecttime = time.time()
@@ -364,6 +378,7 @@ class Bot(object):
                                                self.msg(user, "Command failed. Code: CBEXC%09.3f" % (time.time() % 100000))
                                                self.__debug_cbexception("hook", user=user, target=target, msg=msg)
                                        except SystemExit as e:
+                                               self.parent.mustquit = e
                                                try:
                                                        curs = self.parent.query("UPDATE bots SET connected = 0")
                                                        curs.close()
@@ -395,7 +410,7 @@ class Bot(object):
                In the case of fastmsg, self.conn.exceeded may be True, however, in this case append_callback=self.conn.send, so it will still be sent immediately.
        """
        def _msg(self, target, msg, truncate, append_callback, msgtype):
-               if self.parent.cfg.getboolean('erebus', 'nofakelag'): return self.fastmsg(target, msg)
+               if self.parent.cfg.getboolean('erebus', 'nofakelag'): append_callback = self.conn.send
 
                cmd = self._formatmsg(target, msg, msgtype)
                # The max length is much shorter than recvq (510) because of the length the server adds on about the source (us).
@@ -544,8 +559,17 @@ class BotConnection(object):
        def _write(self, line):
                self.socket.sendall(line.encode('utf-8', 'backslashreplace')+b"\r\n")
 
+       def _getsockerr(self):
+               try: # SO_ERROR might not exist on all platforms
+                       return self.socket.getsockopt(socket.SOL_SOCKET, socket.SO_ERROR)
+               except:
+                       return None
+
        def read(self):
-               self.buffer += self.socket.recv(8192)
+               recvd = self.socket.recv(8192)
+               if recvd == b"":
+                       raise EOFError("socket.recv returned empty", self.parent.nick, self._getsockerr())
+               self.buffer += recvd
                lines = []
 
                while b"\r\n" in self.buffer: