]> jfr.im git - erebus.git/blobdiff - bot.py
fix error handling in reddark
[erebus.git] / bot.py
diff --git a/bot.py b/bot.py
index 51a5b8f2277ff2ab9db9fa0b9450f0b42ffd428d..4b0ecc04b277fdea46dbc9e38d01271ff84e4f43 100644 (file)
--- a/bot.py
+++ b/bot.py
@@ -4,7 +4,7 @@
 # Erebus IRC bot - Author: John Runyon
 # "Bot" and "BotConnection" classes (handling a specific "arm")
 
-import socket, sys, time, threading, os, random
+import socket, sys, time, threading, os, random, struct
 from collections import deque
 
 if sys.version_info.major < 3:
@@ -36,6 +36,11 @@ class Bot(object):
                self.authname = authname
                self.authpass = authpass
 
+               self.connecttime = 0 # time at which we received numeric 001
+               self.server = server # the address we try to (re-)connect to
+               self.port = port
+               self.servername = server # the name of the server we got connected to
+
                curs = self.parent.query("SELECT chname FROM chans WHERE bot = %s AND active = 1", (self.permnick,))
                if curs:
                        chansres = curs.fetchall()
@@ -53,6 +58,7 @@ class Bot(object):
                self.slowmsgqueue = deque()
                self._makemsgtimer()
                self._msgtimer.start()
+               self.joined_chans = False
 
        def __del__(self):
                try:
@@ -95,11 +101,13 @@ class Bot(object):
                one = { #things to look for after source
                        'NOTICE': self._gotconnected,
                        '001': self._got001,
+                       '004': self._got004,
                        '376': self._gotRegistered,
                        '422': self._gotRegistered,
                        'PRIVMSG': self._gotprivmsg,
                        '353': self._got353, #NAMES
                        '354': self._got354, #WHO
+                       '396': self._gotHiddenHost, # hidden host has been set
                        '433': self._got433, #nick in use
                        'JOIN': self._gotjoin,
                        'PART': self._gotpart,
@@ -140,7 +148,10 @@ class Bot(object):
                sys.exit(2)
                os._exit(2)
        def _got001(self, pieces):
-               pass # wait until the end of MOTD instead
+               # We wait until the end of MOTD instead to consider ourselves registered, but consider uptime as of 001
+               self.connecttime = time.time()
+       def _got004(self, pieces):
+               self.servername = pieces[3]
        def _gotRegistered(self, pieces):
                self.conn.registered(True)
 
@@ -149,9 +160,16 @@ class Bot(object):
 
                self.conn.send("MODE %s +x" % (pieces[2]))
                if self.authname is not None and self.authpass is not None:
-                       self.conn.send("AUTH %s %s" % (self.authname, self.authpass))
-               for c in self.chans:
-                       self.join(c.name)
+                       self.conn.send(self.parent.cfg.get('erebus', 'auth_command', "AUTH %s %s") % (self.authname, self.authpass))
+               if not self.parent.cfg.getboolean('erebus', 'wait_for_hidden_host'):
+                       for c in self.chans:
+                               self.join(c.name)
+                       self.joined_chans = True
+       def _gotHiddenHost(self, pieces):
+               if not self.joined_chans and self.parent.cfg.getboolean('erebus', 'wait_for_hidden_host'):
+                       for c in self.chans:
+                               self.join(c.name)
+                       self.joined_chans = True
        def _gotprivmsg(self, pieces):
                nick = pieces[0].split('!')[0][1:]
                user = self.parent.user(nick)
@@ -381,11 +399,20 @@ class Bot(object):
                if self.parent.cfg.getboolean('erebus', 'nofakelag'): return self.fastmsg(target, msg)
 
                cmd = self._formatmsg(target, msg)
-               if len(cmd) > self.conn.recvq:
+               # The max length is much shorter than recvq (510) because of the length the server adds on about the source (us).
+               # If you know your hostmask, you can of course figure the exact length, but it's very difficult to reliably know your hostmask.
+               maxlen = (
+                       self.conn.recvq
+                       - 63 # max hostname len
+                       - 11 # max ident len
+                       - 3  # the symbols in :nick!user@host
+                       - len(self.nick)
+               )
+               if len(cmd) > maxlen:
                        if not truncate:
                                return False
                        else:
-                               cmd = cmd[:self.conn.recvq]
+                               cmd = cmd[:maxlen]
 
                if self.conn.exceeded or self.conn.bytessent+len(cmd) >= self.conn.recvq:
                        append_callback(cmd)
@@ -470,12 +497,21 @@ class BotConnection(object):
                self.state = 0 # 0=disconnected, 1=registering, 2=connected
 
                self.bytessent = 0
-               self.recvq = 400
+               self.recvq = 510
                self.exceeded = False
                self._nowrite = False
 
        def connect(self):
-               self.socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+               if self.parent.parent.cfg.getboolean('erebus', 'tls'):
+                       import ssl
+                       undersocket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+                       context = ssl.create_default_context()
+                       self.socket = context.wrap_socket(undersocket, server_hostname=self.server)
+               else:
+                       self.socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+               self.socket.setsockopt(socket.SOL_TCP, socket.TCP_NODELAY, 1) # Does Python make SOL_TCP portable? Who knows, it's not documented, and it appears to come from the _socket C lib.
+               self.socket.setsockopt(socket.SOL_SOCKET, socket.SO_LINGER, struct.pack('ii', 0, 0))
+               self.socket.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
                self.socket.bind((self.bind, 0))
                self.socket.connect((self.server, self.port))
                return True